Add discussion commenting to smoke workflows with explicit instructions, deprecate discussion flag #11360
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Added github-discussion-query safe-input to all smoke workflows - Added discussions: read permission to all smoke workflows - Added discussion: true flag to add-comment safe-output - Updated compiler to include discussion flag in handler config - Updated workflow prompts to interact with random discussions - Each smoke workflow now picks a random discussion and adds a fun thematic comment Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Smoke Test ResultsPRs Reviewed: Tests:
Status: @pelikhan
|
|
GitHub MCP merged PRs ✅ — [docs] Document --push flag safety features (branch validation and user confirmation); Update schema documentation for removed included_file_schema and remove deprecated safe-jobs field
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test: ClaudePRs Reviewed:
Results:
Status: PARTIAL PASS (7/8)
|
…t gh discussion command (#11371) * Initial plan * Debug discussion-comment task failure - identify root cause Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix github-discussion-query tool to use GraphQL API Replace gh discussion list (unsupported) with gh api graphql. The gh CLI in GitHub Actions doesn't have a 'discussion' subcommand, so we use the GraphQL API to query discussions instead. - Parse repo owner/name from INPUT_REPO or GitHub context - Build GraphQL query for discussions with proper fields - Transform GraphQL output to match expected format - Maintains backward compatibility with existing jq filters Fixes discussion-comment task failure in smoke tests. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Recompile workflows using github-discussion-query tool Recompile all workflows that import shared/github-queries-safe-input.md to apply the GraphQL API fix for discussion queries. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix inline github-discussion-query in daily-performance-summary The daily-performance-summary.md workflow had an inline definition of github-discussion-query that overrides the shared import. Updated the inline definition to also use GraphQL API. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
…all workflows - Updated compiler_safe_outputs_config.go to NOT emit the discussion flag to handler config - Added comment explaining that discussion support is always available in add_comment handler - Recompiled all 137 workflows successfully - Verified daily-fact.lock.yml no longer contains "discussion":true in handler config - The discussion flag is deprecated; add_comment handler auto-detects discussion targets Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Smoke Test: Copilot - PASS ✅
Overall: PASS ✅ Run: §21271197457 cc @pelikhan
|
|
GitHub MCP: ✅ Enable AWF sandbox in dev.md | Update dev workflow to build and test project
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
Smoke Test Results
Status: PASS
|
Smoke workflows now query the latest discussion and post comments to both the discussion and PR to validate discussion functionality. Includes codemod to remove deprecated
discussion: truefield. Workflow prompts include explicit step-by-step instructions for extracting discussion numbers and using the add_comment tool.Changes
Workflow Updates (4 files)
discussions: readpermissionshared/github-queries-safe-input.mdimport forgithub-discussion-querysafe-input tooladd-commentwithmax: 2to allow commenting on both PR and discussiongithub-discussion-querywithlimit=1, jq=".[0]"to get the latest discussion{"number": 123, ...})add_commenttool withdiscussion_number: <extracted_number>to add themed commentdiscussion_numberwhen adding commentsCompiler Update
Modified
pkg/workflow/compiler_safe_outputs_config.goto remove the deprecateddiscussionflag from compiled workflow outputs:discussionboolean flag to handler config JSONadd_commenthandler (auto-detection based on context ordiscussion_numberparameter).lock.ymlfilesCodemod for Migration
Added automated codemod to remove the deprecated
discussionfield from workflow source files:pkg/cli/codemod_discussion_flag.goto automatically removesafe-outputs.add-comment.discussion: truegh aw fix --writeto automatically remove the deprecated field from all workflowsSchema Deprecation
Updated
pkg/parser/schemas/main_workflow_schema.json:discussionfield as deprecated with"deprecated": trueCompiled Outputs
Lock files now include:
discussions: writepermission in the safe_outputs jobadd_commenttool with max: 2 to enable multiple commentsgithub-discussion-querysafe-input tool for querying discussionsdiscussionflag in handler config (deprecated and removed)How It Works
github-discussion-querysafe-input tool with explicit parameters:limit=1, jq=".[0]"{"number": 123, "title": "...", ...})add_commenttool withdiscussion_number: <extracted_number>parameter to add a themed comment to that specific discussionadd_comment(default context)The
add_commenthandler supports commenting on issues, PRs, discussions, issue comments, and PR comments with automatic target type detection.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset
discussionflag into the safe-outputs handler config so workflows can post comments to discussions. Lock files includediscussions: writewhere applicable.Changeset
discussionflag into the safe-outputs handler config so workflows can post comments to discussions. Lock files includediscussions: writewhere applicable.Changeset
discussionflag and add a codemod to remove it.Changeset
discussionflag and add a codemod to remove it.Changeset
discussionflag and add a codemod to remove it. Compiler no longer emits the deprecateddiscussionboolean in handler configs;add_commentauto-detects target type or acceptsdiscussion_number.