Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Aug 12, 2025

We can add these back later once we've done more testing

@dsyme dsyme changed the title Remove ai-inference agentic engine Remove ai-inference, opencode, genaiscript agentic engines for now Aug 12, 2025
@dsyme dsyme merged commit 4263e6d into main Aug 12, 2025
6 checks passed
@dsyme dsyme deleted the dsyme/rm-ai branch August 12, 2025 21:51
pelikhan added a commit that referenced this pull request Aug 22, 2025
…ion (#10) (#185)

* Initial plan

* Add comprehensive unit tests for JavaScript files with Vitest and Makefile targets



* Add coverage/ directory to .gitignore to exclude build artifacts



---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 11, 2025
This commit fixes CodeQL alert #10 (go/unsafe-quoting) in pkg/workflow/redact_secrets.go
by properly escaping single quotes and backslashes before embedding secret references
in YAML strings.

**Issue**: JSON values containing single quotes could break out of enclosing quotes,
potentially leading to command/SQL/code injection (CWE-78, CWE-89, CWE-94).

**Fix**: Added escapeSingleQuote() helper function that:
- Escapes backslashes first to prevent interference
- Escapes single quotes to prevent breaking out of quoted strings
- Applied escaping to all secret references before embedding in YAML

**Security Impact**: Prevents potential injection attacks when secret names contain
special characters that could manipulate the generated YAML structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
github-actions bot added a commit that referenced this pull request Oct 11, 2025
Fixes code scanning alert #10: Potentially unsafe quoting (go/unsafe-quoting)

**Problem:**
The code was using an escaped secret name in the GitHub Actions expression
context (${{ secrets.%s }}), which is incorrect. The escapeSingleQuote()
function escapes single quotes and backslashes for use in single-quoted
YAML strings, but GitHub Actions expressions don't use single quotes.

**Solution:**
Use the original, unescaped secretName in the GitHub Actions expression
since secret names are already validated to only contain safe characters
(uppercase letters, numbers, and underscores) via the validateSecretReferences
function.

The escaped version is still used for the environment variable name prefix
(SECRET_%s) where it's needed for YAML quoting.

**Security Impact:**
This fix prevents potential injection vulnerabilities where escaped
characters could be misinterpreted in the GitHub Actions expression context.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants