-
Notifications
You must be signed in to change notification settings - Fork 36
Remove ai-inference, opencode, genaiscript agentic engines for now #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelikhan
added a commit
that referenced
this pull request
Aug 22, 2025
…ion (#10) (#185) * Initial plan * Add comprehensive unit tests for JavaScript files with Vitest and Makefile targets * Add coverage/ directory to .gitignore to exclude build artifacts --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 11, 2025
This commit fixes CodeQL alert #10 (go/unsafe-quoting) in pkg/workflow/redact_secrets.go by properly escaping single quotes and backslashes before embedding secret references in YAML strings. **Issue**: JSON values containing single quotes could break out of enclosing quotes, potentially leading to command/SQL/code injection (CWE-78, CWE-89, CWE-94). **Fix**: Added escapeSingleQuote() helper function that: - Escapes backslashes first to prevent interference - Escapes single quotes to prevent breaking out of quoted strings - Applied escaping to all secret references before embedding in YAML **Security Impact**: Prevents potential injection attacks when secret names contain special characters that could manipulate the generated YAML structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 11, 2025
Fixes code scanning alert #10: Potentially unsafe quoting (go/unsafe-quoting) **Problem:** The code was using an escaped secret name in the GitHub Actions expression context (${{ secrets.%s }}), which is incorrect. The escapeSingleQuote() function escapes single quotes and backslashes for use in single-quoted YAML strings, but GitHub Actions expressions don't use single quotes. **Solution:** Use the original, unescaped secretName in the GitHub Actions expression since secret names are already validated to only contain safe characters (uppercase letters, numbers, and underscores) via the validateSecretReferences function. The escaped version is still used for the environment variable name prefix (SECRET_%s) where it's needed for YAML quoting. **Security Impact:** This fix prevents potential injection vulnerabilities where escaped characters could be misinterpreted in the GitHub Actions expression context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jan 4, 2026
This was referenced Jan 11, 2026
This was referenced Jan 15, 2026
Merged
This was referenced Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can add these back later once we've done more testing