-
Notifications
You must be signed in to change notification settings - Fork 36
Remove Bearer prefix from safe-inputs authorization headers #9594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Pass the safe inputs api key in the "start MCP gateway" step so that it gets rendered in tbe configuration pass to the gateway. Then it does not need to be provided to the agentic engine step anymore. |
|
@copilot Pass the safe inputs api key in the "start MCP gateway" step so that it gets rendered in tbe configuration pass to the gateway. Then it does not need to be provided to the agentic engine step anymore. |
This is already the current implementation:
The Bearer prefix has been removed in commits 7679fdd and 5585b0f, so the API key is now used as-is in the Authorization header. |
|
💀 Blimey! Changeset Generator failed and walked the plank! No treasure today, matey! ☠️ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
Smoke Test Results - Claude Engine Last 2 Merged PRs:
Test Results: Overall Status: PASS (5/6 tests passed, gh CLI auth expected to fail in this context)
|
Safe-inputs HTTP authorization was incorrectly prefixing API keys with "Bearer ". The API key should be used as-is without modification.
Changes
Authorization header format:
Authorization: Bearer $GH_AW_SAFE_INPUTS_API_KEYAuthorization: $GH_AW_SAFE_INPUTS_API_KEYFiles modified:
pkg/workflow/mcp_renderer.go- TOML format rendererpkg/workflow/safe_inputs_renderer.go- JSON format renderer (Copilot/Claude/Custom engines)pkg/workflow/safe_inputs_http_codex_test.go- Test expectationsExample output (TOML):
Example output (JSON):
{ "safeinputs": { "url": "http://host.docker.internal:$GH_AW_SAFE_INPUTS_PORT", "headers": { "Authorization": "$GH_AW_SAFE_INPUTS_API_KEY" } } }Recompiled affected workflows to apply the authorization format change.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.