Skip runtime detection for containerized MCP servers #9587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified detectFromMCPConfigs to skip MCP servers that are containerized (have Container field set or Type is "docker") - Updated detectSerenaLanguages to return immediately since Serena now runs in container - Updated GenerateSerenaLanguageServiceSteps to return empty slice since services are in container - Fixed tests that expected language service installation steps for Serena - Updated MCP config test expectations to match new containerized format Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unnecessary scanning of mcps for setup actions
Skip runtime detection for containerized MCP servers
Jan 11, 2026
Contributor
|
@copilot recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
pelikhan
approved these changes
Jan 11, 2026
Contributor
|
@copilot merge main |
…tup-dependencies # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
Author
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
|
💀 Blimey! Changeset Generator failed and walked the plank! No treasure today, matey! ☠️ |
Contributor
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Contributor
Smoke Test Results - Claude Engine (Run #20891059098)Last 2 Merged PRs:
Test Results:
Status: PARTIAL PASS (5/6 tests passed)
|
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor runtime detection to skip containerized MCP servers
Since all MCP servers now run in containers, the runtime manager should not scan them for runtime requirements.
Plan
uvxcommand but gets auto-containerized viagetWellKnownContainer()detectFromMCPConfigsinruntime_detection.godetectSerenaLanguages()to return immediately with log messageGenerateSerenaLanguageServiceSteps()to return empty slicemake recompileto regenerate all workflow lock filesmake agent-finishbefore final commitOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.