Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

The missing_tool safe output required both tool and reason parameters, preventing agents from reporting general limitations without naming a specific tool. The MCP server validation rejected calls missing the tool parameter.

Changes

Schema updates (safe_outputs_tools.json, agent-output.json):

  • Changed required: ["tool", "reason"]required: ["reason"]
  • Tool parameter now optional, marked "Optional:" in description

Handler updates (missing_tool.cjs):

  • Removed validation rejecting missing tool field
  • Handler accepts null tool values
  • Conditional logging based on tool presence

Type definitions (safe-outputs.d.ts):

  • Changed tool: stringtool?: string

Usage

// Specific tool (existing behavior)
{ tool: "docker", reason: "Need containerization", alternatives: "Use VM" }

// General limitation (now supported)
{ reason: "Cannot access external APIs", alternatives: "Manual data input" }

All existing tests pass. Added test coverage for optional tool parameter.

Original prompt

Review the missing tool implementation in the safe output MCP server.

The "tool" parameter should be optional and the safe output should take any information to agent deems sharing

See error https://github.com/githubnext/gh-aw/actions/runs/20890839660/job/60021700668#step:45:1 where missing tool fails because missing "tool"


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 11, 2026 06:48
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing tool implementation in safe output MCP server Make tool parameter optional in missing_tool safe output Jan 11, 2026
Copilot AI requested a review from pelikhan January 11, 2026 07:01
@pelikhan pelikhan added the smoke label Jan 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

💀 Blimey! Changeset Generator failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

Claude Engine Smoke Test Results

Last 2 Merged PRs:

Test Results:
✅ GitHub MCP (list_pull_requests)
✅ Playwright (navigated to github.com, title contains "GitHub")
✅ File Writing (created test file successfully)
✅ Bash Tool (verified file creation)
❌ Serena Go (tool not available)
❌ Safe Inputs GH (tool not available)

Status: PARTIAL PASS - Core functionality verified, 2 tools missing

AI generated by Smoke Claude

@pelikhan pelikhan marked this pull request as ready for review January 11, 2026 07:12
@pelikhan pelikhan merged commit 88b48d8 into main Jan 11, 2026
34 of 36 checks passed
@pelikhan pelikhan deleted the copilot/fix-missing-tool-implementation branch January 11, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants