Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

  • Analyze all agentic workflow files in .github/workflows/
  • Only change strict: false to strict: true (30 files)
  • Do NOT add strict: true or sandbox: agent: awf to files without those settings (they should use defaults)
  • Fix daily-multi-device-docs-tester.md permission for strict mode compatibility
  • Keep example-permissions-warning.md as strict: false (intentional example file)
  • Recompile all workflows
  • Update tests to reflect AWF being enabled by default

Summary

Per @pelikhan's feedback: strict: true and sandbox: agent: awf should be defaults.

Changed (30 files): Only workflows that had strict: false → changed to strict: true

Unchanged: Workflows without strict: setting remain unchanged to test the default behavior

Test Updates: Updated tests to verify that AWF sandbox agent is enabled by default for all supported engines (copilot, claude, codex) even without explicit network configuration.

Special cases:

  • daily-multi-device-docs-tester.md: Changed issues: writeissues: read (uses safe-outputs for writes)
  • example-permissions-warning.md: Kept as strict: false (intentional example for permission testing)
Original prompt

Now that awf is integrated with copilot, codex and claude. can you make sure that all the Agentic Workflows in this repo are running in strict mode, and that awf is enabled for all of them (except the workflow that uses other firewall runtime like srt).


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 19, 2025 21:26
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure Agentic Workflows are running in strict mode with awf Enable strict mode and awf firewall for all agentic workflows Dec 19, 2025
Copilot AI requested a review from Mossaka December 19, 2025 21:49
@pelikhan
Copy link
Contributor

@copilot script: true and sandbox: agent: awf should be the default so do not edit workflows that do not have strict: ... specified so we also test the defaults.

Per feedback, strict: true and sandbox: agent: awf should be defaults.
Only workflows that explicitly had strict: false are changed to strict: true.
Workflows without strict: setting remain unchanged to test defaults.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

@copilot script: true and sandbox: agent: awf should be the default so do not edit workflows that do not have strict: ... specified so we also test the defaults.

Addressed in dcbcc58. Now only workflows that explicitly had strict: false are changed to strict: true (30 files). Files without strict: or sandbox: settings remain unchanged to test the defaults.

Copy link
Contributor

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot make sure the awf sandbox agent is enabled by default if not specified

Tests now expect AWF sandbox agent to be enabled by default for all
supported engines (copilot, claude, codex) even without explicit
network configuration.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

@copilot make sure the awf sandbox agent is enabled by default if not specified

Verified in e45c54f. AWF sandbox agent is already enabled by default when no sandbox.agent is specified. Updated tests to confirm this behavior - AWF is now enabled by default for all supported engines (copilot, claude, codex) even without explicit network configuration.

Copilot AI requested a review from pelikhan December 19, 2025 22:36
@Mossaka Mossaka marked this pull request as ready for review December 19, 2025 23:20
@Mossaka Mossaka added the smoke label Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

Smoke Test Results (Run 20385131313)

Last 2 Merged PRs:

✅ GitHub MCP - Retrieved PRs
✅ File Writing - Created test file
✅ Bash Tools - Verified file
✅ get_me Tool - Correctly unavailable (expected behavior with default toolsets)
✅ Cache Memory - Created and verified

Overall: PASS

cc @Mossaka

📰 BREAKING: Report filed by Smoke Copilot fer issue #7009 🗺️

@github-actions
Copy link
Contributor

#7010 Fix smoke-codex-firewall test to expect OpenAI access blocked
#7007 Restructure Agentic campaigns docs into subsections
OpenAI curl blocked: ✅
GitHub MCP PR fetch: ✅
File write/read: ✅
example.com blocked: ✅
Network: SANDBOXED
Overall: PASS

🔥 Firewall tested by Smoke Codex Firewall fer issue #7009 🗺️

@github-actions
Copy link
Contributor

Smoke Test Results: Copilot Engine (No Firewall)

Last 2 Merged PRs:

Test Results:

  1. GitHub MCP ✅
  2. File Writing ✅
  3. Bash Tool ✅
  4. Playwright MCP ✅ (title contains "GitHub")
  5. Safe Input gh Tool ❌ (tool not available)

Overall: PASS (4/5 critical tests passed)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #7009 🗺️

@github-actions
Copy link
Contributor

Smoke Test Results

Last 2 Merged PRs: Unable to test (GitHub MCP not available)
File Writing: ✅ Created and verified /tmp/gh-aw/agent/smoke-test-copilot-20385131297.txt
Bash Tools: ✅ Successfully executed file operations
Serena MCP: Unable to test (Serena MCP not available)
Safe Input gh: Unable to test (safeinputs-gh tool not available)

Overall Status: PARTIAL PASS (2/5 tests completed)

Ahoy! This treasure was crafted by 🏴‍☠️ Smoke Copilot Safe Inputs fer issue #7009 🗺️

@github-actions
Copy link
Contributor

Recent merged PRs: Fix smoke-codex-firewall test to expect OpenAI access blocked; Make MCP configuration default in init command, add --no-mcp flag
GitHub MCP: ✅
Agent file write/read: ✅
Playwright title contains "GitHub": ✅
Cache memory write/read: ✅
safeinputs-gh gh issues list: ❌ (tool unavailable)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #7009 🗺️

@github-actions
Copy link
Contributor

Smoke Test Results - Claude (Run 20385131306)

Recent PRs:

Test Results:

  • ✅ GitHub MCP (last 2 PRs fetched)
  • ✅ File Writing (/tmp/gh-aw/agent/)
  • ✅ Bash Tool (file verification)
  • ✅ Playwright MCP (GitHub page title confirmed)
  • ✅ Cache Memory (/tmp/gh-aw/cache-memory/)
  • ❌ Safe Input gh Tool (tool not available, alternatives available)

Status: PASS (5/6 tests successful, gh tool missing but alternatives exist)

💥 [THE END] — Illustrated by Smoke Claude fer issue #7009 🗺️

@pelikhan pelikhan merged commit 1cb5173 into main Dec 19, 2025
96 of 97 checks passed
@pelikhan pelikhan deleted the copilot/enable-awf-strict-mode branch December 19, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants