Fix smoke-codex-firewall test to expect OpenAI access blocked #7010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test incorrectly expected OpenAI domain access via curl to succeed. However, OpenAI domains are NOT in the `defaults` or `github` network ecosystems - they are only added by the Codex CLI engine itself. This fix updates the test to correctly expect curl access to OpenAI domains to be BLOCKED, validating the firewall is working correctly. Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix run failure in CI pipeline
Fix smoke-codex-firewall test to expect OpenAI access blocked
Dec 19, 2025
Mossaka
approved these changes
Dec 19, 2025
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoke-codex-firewall test incorrectly expected curl access to OpenAI domains to succeed, claiming they are "in the default allowed domains." This is wrong:
CodexDefaultDomains, not thedefaultsnetwork ecosystemGetCodexAllowedDomains()only adds OpenAI domains when the Codex CLI itself runsChanges
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.