Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to remote commit #97

Closed
wants to merge 1 commit into from
Closed

Conversation

mtsmfm
Copy link

@mtsmfm mtsmfm commented Jun 18, 2017

Hi
Thank you for creating awesome extension 😄

BTW, I think it is useful if we can open in remote by clicking commit.

screen shot 2017-06-19 at 3 56 13

What do you think?

@eamodio
Copy link
Member

eamodio commented Jun 20, 2017

@mtsmfm I think this is a great idea and have been thinking about something similar. The issue is that vscode doesn't support command: in the hovers right now. But you prompted me to open microsoft/vscode#29076 and send a PR microsoft/vscode#29082 :)

If this gets accepted I will look into adding a similar feature -- although I would have it open the commit details quickpick rather than open in remote as that is more flexible.

Thanks again for your PR and push!

@mtsmfm
Copy link
Author

mtsmfm commented Jun 20, 2017

@eamodio Thanks quick response!

Hmm, in my environment (vscode Version 1.13.1), my patch works well:

lens

@eamodio
Copy link
Member

eamodio commented Jun 20, 2017

@mtsmfm wow you are right -- I'm always running the Insiders build and it looks like it only doesn't work there -- I'll dig more into it. Thanks!

@eamodio
Copy link
Member

eamodio commented Jun 22, 2017

@mtsmfm Currently it looks like this feature has been pulled because of security concerns with malicious content in hovers -- see microsoft/vscode#29076

I hope they can be convinced to not pull the feature completely, but instead change it to mitigate the security concerns.

@eamodio
Copy link
Member

eamodio commented Sep 11, 2017

@mtsmfm FYI, I've added this feature to GitLens v5. Thanks again for the PR, but unfortunately given the vscode API changes and the fact that I wanted the hover commands to open the details quick pick -- I'm closing this PR.

@eamodio eamodio closed this Sep 11, 2017
billsedison added a commit to noside911/vscode-gitlens that referenced this pull request Jan 4, 2019
implement static autocomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants