Allow links in hover decorations to be inside a <code> tag #29082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. code tags
eamodio
force-pushed
the
feature-hover-commands
branch
from
ca6b39b to
2de1f86
Compare
eamodio
changed the title
command: links in hover decorations
|
Any chance this could make it in for August? I'd love to be able to keep the GitLens hover styling, but also allow command links. |
|
@jrieken Any chance for the august milestone for this? 🤞 |
|
I am good with it. Wake up @mjbvz |
|
Thanks @eamodio! Should be in next insiders build |
|
Awesome thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29076
Allows link actions when links are embedded inside another tag -- e.g.
<code>tagsFor example in GitLens I want to add the following command links:
And I'd like to keep the
<code>tag styling on them.@mjbvz @jrieken I've repurposed this PR to just allow the above.