Fix for new navigation #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filiptronicek you want to link WEB-116 to fix/close? |
This is a neat lil' feature, nice |
filiptronicek
commented
Apr 18, 2023
Comment on lines
+18
to
+28
| function isNewNavigation(): boolean { | ||
| if (select.exists(".file-navigation")) { | ||
| return false; | ||
| } | ||
| const newNavigationFileHelperElement = 'button[data-hotkey="t,T"][hidden]'; | ||
| if (select.exists(newNavigationFileHelperElement)) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This is the important bit, it's hacky, but works for now. For the transitioning phase it should work and we can adjust.
|
I fixed the underlying problem as part of this PR. So I believe this PR is no longer needed and can be closed. Let me know if missed anything (and sorry I saw it too late). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the extension to work in the new GitHub navigation public beta.
Related Issue(s)
Fixes WEB-116
People noticing on Slack:
How to test
Release Notes
Documentation