Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to new GH repo overview #80

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add button to new GH repo overview #80

merged 1 commit into from
Jul 31, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jul 30, 2023 •
edited
Loading

  • Adds the button to the new repo overview
  • updates webpack and other libs
  • adds source maps to the build for better debuggability
  • makes gp button on issues secondary.
  • moves gp button on PRs to the right

@svenefftinge svenefftinge force-pushed the se/some-fixes branch 2 times, most recently from 5a093f7 to c8756e5 Compare July 30, 2023 21:32
@svenefftinge svenefftinge mentioned this pull request Jul 30, 2023
Closed
Siddhant-K-code
Siddhant-K-code approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works like a charm 😍❤️

  • ✨ This even works with the latest layout (in Private Beta) of GitHub:
    image

  • Code LGTM (have some minor non-blocking comments) ✅

One thing, we should do is bump browser extension version in the manifest file to 1.19.

browser-extension/manifest.json

Line 5 in 748887b

"version": "1.18",

This is because, when we would release the extension to Browser Extension stores, it would trigger browser APIs to update the extension to latest.

webpack.config.js Show resolved Hide resolved
filiptronicek
filiptronicek approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@svenefftinge svenefftinge merged commit 4b9e68c into master Jul 31, 2023
@svenefftinge svenefftinge deleted the se/some-fixes branch July 31, 2023 07:21
@gtsiolis
Copy link
Contributor

Closing also gitpod-io/gitpod#14117 and gitpod-io/gitpod#18375.

This was referenced Jul 31, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svenefftinge @gtsiolis @filiptronicek @Siddhant-K-code