Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to be able to identify leaking prebuild #10383

Closed
geropl opened this issue May 31, 2022 · 3 comments · Fixed by #10435
Closed

Add metrics to be able to identify leaking prebuild #10383

geropl opened this issue May 31, 2022 · 3 comments · Fixed by #10435
Assignees
Labels
operations: observability This issue relates to the observability of Gitpod (metrics, logs, traces) type: improvement Improves an existing feature or existing code

Comments

@geropl
Copy link
Member

geropl commented May 31, 2022

Came up in the context of:

First idea:

  • have counters on "queued" (WorkspaceFactory in server), "running" and end states ("available", "failed", in bridge, while making sure to only capture flanks 👍 )
  • subtracting those should give a fairly good trend
@geropl geropl added type: improvement Improves an existing feature or existing code operations: observability This issue relates to the observability of Gitpod (metrics, logs, traces) labels May 31, 2022
@geropl geropl mentioned this issue May 31, 2022
11 tasks
@geropl
Copy link
Member Author

geropl commented Jun 1, 2022

Summary of discussion with @laushinka 👍 :

  • (init) decision "do we want to run this"?:
    • no: "aborted"
    • yes: "queued"
      • -> "running" -> end state
      • -> end state
      • end state is:
        • system error: "failed" | "timeout"
        • user error: "aborted" (stopped by request) | "available" + error (user tasks failed)
  • maybe create an image fo the state machine here?

@geropl
Copy link
Member Author

geropl commented Jun 1, 2022

metrics:

  • a) prebuild_state_counter { state }
  • b) prebuild_started_counter + prebuild_finished_counter
  • c) ...?

@laushinka laushinka self-assigned this Jun 1, 2022
@laushinka laushinka moved this to Scheduled in 🍎 WebApp Team Jun 1, 2022
@laushinka laushinka moved this from Scheduled to In Progress in 🍎 WebApp Team Jun 1, 2022
@laushinka
Copy link
Contributor

Just noticed that we have prebuild_queue_size metric which is not used anywhere it seems.

Repository owner moved this from In Progress to Done in 🍎 WebApp Team Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations: observability This issue relates to the observability of Gitpod (metrics, logs, traces) type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants