Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prebuilds] add metrics for prebuilds 10383 #10435

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[prebuilds] add metrics for prebuilds 10383 #10435

merged 1 commit into from
Jun 9, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Jun 2, 2022 •
edited
Loading

Description

Provides counter metrics for prebuilds with states as labels.

  • gitpod_prebuilds_started_total ("queued")
  • gitpod_prebuilds_completed_total ("available", "failed", "timeout", "aborted" )

Related Issue(s)

Fixes #10383

How to test

  1. Trigger prebuilds
  2. Check that those prebuilds show up on this Prometheus query page[1]

Release Notes

NONE

Documentation

/werft run with-observability

@laushinka laushinka force-pushed the laushinka/metrics-10383 branch 3 times, most recently from e97d10a to f2e58d8 Compare June 3, 2022 09:53
@laushinka laushinka marked this pull request as ready for review June 3, 2022 09:55
@laushinka laushinka requested a review from a team June 3, 2022 09:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 3, 2022
@laushinka laushinka changed the title Laushinka/metrics 10383 [prebuilds] add metrics for prebuilds 10383 Jun 3, 2022
@laushinka laushinka requested a review from geropl June 3, 2022 10:02
easyCZ
easyCZ previously requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about semantics of the metrics.

@laushinka laushinka marked this pull request as draft June 7, 2022 10:15
@laushinka laushinka force-pushed the laushinka/metrics-10383 branch from f2e58d8 to 22b2afb Compare June 7, 2022 11:48
@roboquat roboquat added size/M and removed size/S labels Jun 7, 2022
@laushinka laushinka marked this pull request as ready for review June 7, 2022 12:06
@laushinka laushinka requested a review from easyCZ June 7, 2022 12:08
@laushinka laushinka force-pushed the laushinka/metrics-10383 branch from 22b2afb to 8d41d36 Compare June 7, 2022 12:53
@laushinka laushinka force-pushed the laushinka/metrics-10383 branch from 8d41d36 to 91da6e6 Compare June 7, 2022 13:16
@laushinka laushinka requested a review from easyCZ June 7, 2022 13:17
@laushinka laushinka force-pushed the laushinka/metrics-10383 branch from 91da6e6 to cd00abe Compare June 7, 2022 14:27
@geropl
Copy link
Member

geropl commented Jun 8, 2022

@laushinka Starting to review now.

@laushinka laushinka force-pushed the laushinka/metrics-10383 branch from cd00abe to 3a4abdf Compare June 8, 2022 09:28
@laushinka laushinka requested a review from geropl June 8, 2022 10:39
geropl
geropl approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @laushinka , the metrics/code look good!

Now waiting for the build to properly report as green 🙄

@geropl
Copy link
Member

geropl commented Jun 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-laushinka-metrics-10383.16
(with .werft/ from main)

@geropl geropl self-assigned this Jun 8, 2022
@laushinka
Copy link
Contributor Author

laushinka commented Jun 8, 2022 •
edited
Loading

Now waiting for the build to properly report as green 🙄

Thanks! Yeah this happened earlier today as well, and rerunning did it 🙏🏽🤞🏼 I'll keep an eye on it

@laushinka laushinka dismissed easyCZ’s stale review June 9, 2022 06:52

Requested changes are done

@roboquat roboquat merged commit 6525911 into main Jun 9, 2022
@roboquat roboquat deleted the laushinka/metrics-10383 branch June 9, 2022 06:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ left review comments

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics to be able to identify leaking prebuild
4 participants
@laushinka @geropl @easyCZ @roboquat