Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove d_b_billed_session and corresponding usage #13009

Closed
3 tasks
easyCZ opened this issue Sep 15, 2022 · 6 comments
Closed
3 tasks

Remove d_b_billed_session and corresponding usage #13009

easyCZ opened this issue Sep 15, 2022 · 6 comments
Assignees
@easyCZ
Labels
team: webapp Issue belongs to the WebApp team

Comments

@easyCZ
Copy link
Member

easyCZ commented Sep 15, 2022

We've introduced the d_b_billed_session to track usage between Stripe and Chargebee, but we're not planning to use it goign forward. We can clean up.

Clean up the following:

  • Calls into BillingService.SetBilledSessions
  • Remove API BillingService.SetBilledSessions
  • Once we confirm no usage, remove the table
@laushinka
Copy link
Contributor

@easyCZ Are you working on this?

@easyCZ easyCZ self-assigned this Sep 15, 2022
@easyCZ easyCZ moved this from Scheduled to In Progress in 🍎 WebApp Team Sep 15, 2022
@easyCZ easyCZ mentioned this issue Sep 15, 2022
Merged
1 task
@easyCZ
Copy link
Member Author

easyCZ commented Sep 15, 2022

To remove the calls: #13011

@easyCZ easyCZ mentioned this issue Sep 15, 2022
Merged
1 task
@easyCZ
Copy link
Member Author

easyCZ commented Sep 15, 2022

Remove RPC implementation: #13012
Remove proto definition: #13013
Remove Go DB model: #13014

Once these land, we can also drop the table.

@easyCZ easyCZ mentioned this issue Sep 19, 2022
Merged
1 task
@easyCZ
Copy link
Member Author

easyCZ commented Sep 19, 2022

Removal of table: #13009

@easyCZ
Copy link
Member Author

easyCZ commented Sep 19, 2022

Bumping to 5k instances every run #13073

@easyCZ easyCZ moved this from In Progress to Done in 🍎 WebApp Team Sep 19, 2022
@geropl
Copy link
Member

geropl commented Sep 23, 2022

@easyCZ Is this already "Done", or rather "in progress"?

@geropl geropl closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@easyCZ easyCZ

Labels
team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@easyCZ @laushinka @geropl