Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[billing] Remove implementation of SetBilledSession RPC #13012

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 15, 2022

Description

This RPC is no longer needed (after #13011 lands and is validated).

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ force-pushed the mp/usage-stop-invoking-set-billed branch from 5341df0 to 9ef2721 Compare September 15, 2022 14:53
Base automatically changed from mp/usage-stop-invoking-set-billed to main September 15, 2022 22:59
@roboquat roboquat added size/M and removed size/S labels Sep 15, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Sep 16, 2022

/hold to be landed after we've rolled out removal of traffic and confirmed there is no more traffic

@easyCZ easyCZ force-pushed the mp/usage-remove-billed-sessions-impl branch from a80aea7 to 430ff78 Compare September 16, 2022 06:53
@easyCZ easyCZ marked this pull request as ready for review September 16, 2022 06:53
@easyCZ easyCZ requested a review from a team September 16, 2022 06:53
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 16, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Sep 16, 2022

/unhold

@roboquat roboquat merged commit d9f460b into main Sep 16, 2022
@roboquat roboquat deleted the mp/usage-remove-billed-sessions-impl branch September 16, 2022 11:16
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants