Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display the absolute time in a tooltip when using the relative date and time format #13764

Closed
gtsiolis opened this issue Oct 11, 2022 · 7 comments · Fixed by #17234 or #17431
Closed
Assignees
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

We've been using relative and absolute date and time formats across the product. For example, see projects, members, and usage for the Gitpod team in Gitpod.io.

Generally, both absolute and relative formats can be useful depending on each use case. 💡

🅰️ Relative date and time can be useful when the content is updated frequently and surfacing an absolute date is not critical, etc.
🅱️ Absolute date and time makes sense when users would need to convert the date in order to complete a task, etc.

Proposal

In any case, I think we can safely use the following guideline across the product:

When using the relative format, always display the absolute time in a tooltip.

This issue acts as a placeholder for adding a tooltip on all relative date and time formats used across the product. 🛹

Next steps

Future next steps include:

  1. Documenting this as a guideline.
  2. Introducing more sophisticated guidelines on when to use which.
  3. Explain in detail date and time format options and how to use them.
@stale
Copy link

stale bot commented Jan 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 10, 2023
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Jan 10, 2023
@oyetanishq
Copy link
Contributor

Hey @gtsiolis, I would like to work on this issue.

@gtsiolis
Copy link
Contributor Author

Hey @tanishq-singh-2301! Feel free to open a PR and link back to this issue. I'd recommend breaking down changes into smaller pieces in an MVC approach for faster reviews and turnarounds. 🛹

@oyetanishq
Copy link
Contributor

@gtsiolis This is my first issue in gitpod, I'm not able to find any contribution and installation guide??

@gtsiolis
Copy link
Contributor Author

Hi @tanishq-singh-2301! Re-posting from #15669 (comment):

  1. Contributing to Gitpod can be more complicated than other projects because of the nature of the project working on top of Kubernetes cluster, etc.
  2. For the dashboard component, you can find some basic instructions in the relevant folder, but we have not been actively maintaining that README file.
  3. We develop Gitpod in Gitpod which means we're not running Gitpod locally to develop it.
  4. Usually community contributors push a new branch or a new PR and we help by spinning a preview environment for them which deploys a preview installation of Gitpod where you can connect later with telepresence and make changes.

@oyetanishq
Copy link
Contributor

oyetanishq commented Jan 17, 2023

Hi @gtsiolis I got it setup, but I'm not able to create or view teams.
It's giving me error HTTP 404 If I try to create a new team.
How do I access that page??

image

@oyetanishq
Copy link
Contributor

oyetanishq commented Jan 17, 2023

Hi @gtsiolis I got it setup, but I'm not able to create or view teams. It's giving me error HTTP 404 If I try to create a new team. How do I access that page??

image

here is an update!!
I noticed that api call was responding with 404, So I added this piece of code.
To proxy /public-api to gitpod.io/public-api

// craco.config.js

"/public-api": {
     target: "https://" + process.env.GP_DEV_HOST,
     ws: true,
     headers: {
         host: process.env.GP_DEV_HOST,
         origin: "https://" + process.env.GP_DEV_HOST,
         cookie: process.env.GP_DEV_COOKIE,
     },
},

Now It's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment