Add tooltip with absolute date and time on relative times #17431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
commented
Apr 28, 2023
There was a problem hiding this comment.
Thanks for your patience, @tanishq-singh-2407!
UX and code changes LGTM! 🏁
You can check the changes in the preview environment.
There are some instances of relative times which could benefit from a tooltip with the absolute date and time, like the workspaces list, but let's not block merging this. We can add any more tooltips with absolute date and time in separate PRs.
Leaving this to @gitpod-io/engineering-webapp for approval as I can't approve as author.
|
Thanks for taking a look, @geropl. 🌮 🌮 /unhold |
svenefftinge
pushed a commit
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Tanishq Singh <tanishqsingh640@gmail.com>
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick up changes from the community contribution in #17234. Cc @tanishq-singh-2407
For more context, see relevant section in How we develop.
Related Issue(s)
Fixes #13764
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold