Skip to content

Show only stable or latest editor options from the new workspace modal #16831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Mar 13, 2023 · 7 comments
Closed
Labels
component: dashboard feature: ide-selection meta: stale This issue/PR is stale and will be closed soon team: IDE type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 13, 2023

Problem to solve

The recently updated new workspace modal includes a list of all available editor options, including the latest versions—that is Insiders for VS Code and EAP for JetBrains.

However, this modal is not necessarily targeting power users who would need the option to use the latest editor in this modal. This leads to a more confusing and verbose UI/UX.

The option still remains available at reach inside user settings for any power user who wants to get the latest updates for the editor options.

See relevant discussion (internal). Cc @loujaybee @filiptronicek @akosyakov @mbrevoort

See relevant discussion point (internal) from a recent design check-in. 🍳

Proposal

Remove the latest editor options from the new workspace modal.

@akosyakov
Copy link
Member

How is it going to play with user setting? We should show then VS Code Insiders Desktop then in New Workspace dialog?

@akosyakov akosyakov moved this to Scheduled in 🚀 IDE Team Mar 13, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 13, 2023

@akosyakov I'll make an (expensive) assumption here that users overriding the editor don't necessarily need to switch between the latest or not.

☝️ Collecting some metrics around this could shed some light on this. Re-posting relevant discussion point (internal) from a recent design check-in. 🍳


If this sound acceptable, I'd keep the latest checkbox as opt-in only in user settings and only allow control from there.

This way, changing the editor on the new workspace modal will respect the option of the latest or not from user settings, but 🅰️ not list explicitly all options in the new workspace modal and 🅱️ default and surface stable or latest based on the editor list, showing only one option per editor. Does this sound like a good way forward?

@gtsiolis gtsiolis changed the title Remove the latest editor options from the new workspace modal Show only stable or latest editor options from the new workspace modal Mar 13, 2023
@akosyakov
Copy link
Member

Yes, I agree to list only one option based on user setting. The question was about naming. We could keep showing latest label indeed. I still think that using proper product names is better. I don’t think someone knows what is VS Code desktop latest.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 13, 2023

Yes, I agree to list only one option based on user setting.

DEAL—🤝

The question was about naming. We could keep showing latest label indeed. I still think that using proper product names is better. I don’t think someone knows what is VS Code desktop latest.

DEAL—Once the user opt-in to using the latest using the checkbox input in user settings, we can then show Insiders or EAP as the label next to the editor in the new workspace modal, see designs below how we could also surface this on the current editor selection cards. 🃏

Then, once #13116 lands, we can simply replace the editor cards with the same exact compact dropdown.

BEFORE AFTER
editos-before editos-after

@filiptronicek
Copy link
Member

filiptronicek commented Mar 13, 2023

we can then show Insiders or EAP

I like this 🙌: around release dates, it does happen that VS Code Browser Stable == VS Code Browser Insiders - see internal thread for an example (I believe the same can happen for JB). With this we can show the version as non-insiders even if Insiders is chosen in the user prefs. Related: #15251

@stale
Copy link

stale bot commented Jun 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 11, 2023
@filiptronicek
Copy link
Member

Actually already fixed by #16847.

@github-project-automation github-project-automation bot moved this from Scheduled to Done in 🚀 IDE Team Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: ide-selection meta: stale This issue/PR is stale and will be closed soon team: IDE type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

No branches or pull requests

3 participants