Skip to content

Tag VS Code Insiders versions accordingly #15251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

filiptronicek
Copy link
Member

Description

When building VS Code Browser images, take a look at whether it's a stable or insiders release and if the latter, tag it as such (e.g. 1.74.0-insider). Previously, we did not take quality into account.

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2022

@filiptronicek: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ft-tag-vscode-insiders-with-corresponding-suf.1 because the annotations in the pull request description changed
(with .werft/ from main)

@stale
Copy link

stale bot commented Dec 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 20, 2022
@filiptronicek filiptronicek removed the meta: stale This issue/PR is stale and will be closed soon label Dec 20, 2022
@stale
Copy link

stale bot commented Dec 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 31, 2022
@stale stale bot closed this Jan 7, 2023
@filiptronicek filiptronicek deleted the ft/tag-vscode-insiders-with-corresponding-suffix branch February 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants