Skip to content

Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal #13116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Sep 20, 2022 · 6 comments · Fixed by #16847
Assignees
Labels
component: dashboard team: IDE type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 20, 2022

Problem to solve

Currently, we're using the SelectableCardSolid component in multiple areas in the dashboard like the Editor, Workspaces, etc.

While the options for Editor and Workspaces will grow over time, they will always remain finite. See #7751 and #12708.

However, this card component can not scale well after adding too many options, especially when the card will have to contain multiple rows of information like the Workspaces (class) selection.

See also relevant discussion (internal). Cc @loujaybee

Proposal

Introduce a new, more flexible component or pattern like a dropdown that is able to scale better for selecting from a range of options like the Editor and Workspaces.`

Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal.

See relevant discussion (internal). Cc @akosyakov

BEFORE / AFTER
editor
@gtsiolis gtsiolis added component: dashboard needs visual design type: improvement Improves an existing feature or existing code labels Sep 20, 2022
@gtsiolis gtsiolis changed the title Improve editor selection components to scale better with more options Improve editor and workspace class selection components to scale better with more options Sep 20, 2022
@loujaybee
Copy link
Member

Note: Also affects the IDE selection during onboarding flow.

@gtsiolis gtsiolis changed the title Improve editor and workspace class selection components to scale better with more options Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal Jan 20, 2023
@jeanp413 jeanp413 moved this to Scheduled in 🚀 IDE Team Feb 6, 2023
@loujaybee
Copy link
Member

Can we hold off on this for now? @geropl is talking to WebApp team, and @selfcontained might pick this up 🙏

@loujaybee loujaybee removed the status in 🚀 IDE Team Feb 15, 2023
@laushinka
Copy link
Contributor

laushinka commented Mar 7, 2023

Can we hold off on this for now? @geropl is talking to WebApp team, and @selfcontained might pick this up 🙏

What's the status of this? In case IDE can pick it back up.

@filiptronicek
Copy link
Member

@gtsiolis after the discussions in #16831, should we leave the Latest button in the preferences and dynamically change the dropdown contents or make it static without the button (include everything) as the original design in the PR description suggests?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 14, 2023

@filiptronicek From what I understand, we can safely keep the Latest checkbox option in settings to catch both VS Code and JetBrains editor cases, regardless if we replace the cards with the dropdown.

Regarding the beta notice in the issue description above, we could either drop it, keep it all the time, or show a small note below the dropdown when users select a JetBrains editor, see screenshots below. Cc @loujaybee @akosyakov

Editors dropdown Editors dropdown with beta notice
Editors Editors-1

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 14, 2023

@filiptronicek I'm adding below a minor correction in the dropdown to match the expectations from the relevant discussion (internal) earlier today and the upcoming changes in #15252. Feedback is welcome!

Editor dropdown Editor dropdown with beta notice
Editors Editors-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: IDE type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants