-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal #13116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note: Also affects the IDE selection during onboarding flow. |
Can we hold off on this for now? @geropl is talking to WebApp team, and @selfcontained might pick this up 🙏 |
What's the status of this? In case IDE can pick it back up. |
@filiptronicek From what I understand, we can safely keep the Latest checkbox option in settings to catch both VS Code and JetBrains editor cases, regardless if we replace the cards with the dropdown. Regarding the beta notice in the issue description above, we could either drop it, keep it all the time, or show a small note below the dropdown when users select a JetBrains editor, see screenshots below. Cc @loujaybee @akosyakov
|
@filiptronicek I'm adding below a minor correction in the dropdown to match the expectations from the relevant discussion (internal) earlier today and the upcoming changes in #15252. Feedback is welcome!
|
Problem to solve
Currently, we're using the
SelectableCardSolid
component in multiple areas in the dashboard like the Editor, Workspaces, etc.While the options for Editor and Workspaces will grow over time, they will always remain finite. See #7751 and #12708.
However, this card component can not scale well after adding too many options, especially when the card will have to contain multiple rows of information like the Workspaces (class) selection.
See also relevant discussion (internal). Cc @loujaybee
Proposal
Introduce a new, more flexible component or pattern like a dropdown that is able to scale better for selecting from a range of options like the Editor and Workspaces.`Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal.
See relevant discussion (internal). Cc @akosyakov
The text was updated successfully, but these errors were encountered: