Better looking version strings in the Dashboard #15252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

filiptronicek wants to merge 2 commits into main from ft/dashboard-ides-nice-versions

Member

filiptronicek commented Dec 8, 2022

Description

This PR makes sure that in the IDE selector, we prettify version string containing hyphens.

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

roboquat added the do-not-merge/work-in-progress label

Contributor

roboquat commented Dec 8, 2022

@filiptronicek: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roboquat added the do-not-merge/release-note-label-needed label

werft-gitpod-dev-com bot commented Dec 8, 2022

started the job as gitpod-build-ft-dashboard-ides-nice-versions.1 because the annotations in the pull request description changed
(with .werft/ from main)

roboquat added the size/S label

gtsiolis mentioned this pull request

Update the design of the editor selection cards #15194

Closed

stale bot commented Dec 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

filiptronicek removed the meta: stale label

stale bot commented Dec 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

filiptronicek removed the meta: stale label

stale bot commented Jan 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

filiptronicek marked this pull request as ready for review

January 19, 2023 17:11

filiptronicek requested a review from a team

January 19, 2023 17:11

roboquat removed the do-not-merge/work-in-progress label

stale bot removed the meta: stale label

github-actions bot added the team: webapp label

Contributor

selfcontained commented Jan 23, 2023 •

edited by werft-gitpod-dev-com bot

Loading

/werft run

👍 started the job as gitpod-build-ft-dashboard-ides-nice-versions.2
(with .werft/ from main)

stale bot commented Feb 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

svenefftinge reviewed

View reviewed changes

components/dashboard/src/settings/SelectIDE.tsx Outdated Show resolved Hide resolved

stale bot removed meta: stale labels

stale bot commented Mar 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

filiptronicek requested a review from gtsiolis as a code owner

March 14, 2023 14:18

roboquat added size/M and removed size/S labels

stale bot removed meta: stale labels

filiptronicek force-pushed the ft/dashboard-ides-nice-versions branch from 3cca423 to 60923cd Compare

March 14, 2023 14:32

filiptronicek added 2 commits

March 14, 2023 14:42


          Better looking version strings in the Dashboard

6c955c5


          Update for <SelectIDEComponent />

e2f26e4

filiptronicek force-pushed the ft/dashboard-ides-nice-versions branch from 60923cd to e2f26e4 Compare

March 14, 2023 14:42

gtsiolis mentioned this pull request

Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal #13116

Closed

stale bot commented Mar 24, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the meta: stale label

stale bot closed this

filiptronicek deleted the ft/dashboard-ides-nice-versions branch

January 24, 2024 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/release-note-label-needed meta: stale size/M team: webapp