Skip to content

Select editor non-scrollable modal UX adds friction to onboarding flow #13570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jldec opened this issue Oct 4, 2022 · 3 comments
Closed

Select editor non-scrollable modal UX adds friction to onboarding flow #13570

jldec opened this issue Oct 4, 2022 · 3 comments

Comments

@jldec
Copy link
Contributor

jldec commented Oct 4, 2022

New users are prompted to select an editor after they sign in.

Unfortuntately this modal does not scroll and the action button is off screen for normal sized desktop browsers already taking up a the full height of the screen.

Clicking on the default editor selection does not submit or dismiss the form.

Since part of the form is obscured, a cautious user will look for the cancel/dismiss control and probably click on the X at the top right hoping that this does not have unintended consequences. This adds uncertainty into the flow and forces additional work to find the X.

Screenshot 2022-10-04 at 09 55 15

@jldec
Copy link
Contributor Author

jldec commented Oct 4, 2022

Related to #13116
cc: @gtsiolis @loujaybee

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

Closing this as a duplicate of #13497, which already contains a good MVC solution. Cc @andreafalzetti

Thanks for noticing, @jldec!

@gtsiolis gtsiolis closed this as completed Oct 4, 2022
@gtsiolis gtsiolis moved this to Done in 🚀 IDE Team Oct 4, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

Just noticed there's a community contributor who already picked this up in #13557.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants