-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two rows of 4 option on onboarding IDE selector #13557
Conversation
started the job as gitpod-build-measutosh-patch-1.0 because the annotations in the pull request description changed |
/werft run with-preview 👍 started the job as gitpod-build-measutosh-patch-1-fork.0 |
/werft run with-preview 👍 started the job as gitpod-build-measutosh-patch-1-fork.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @measutosh! 🍊
You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓
UX changes look good! ✔️
Someone from the @gitpod-io/engineering-webapp
will pick this up for a code review. 🏀
Very quick, @svenefftinge! Was the CLA signed yet? |
thanks @gtsiolis for the MR |
Probably not. I was expecting that it wouldn't get merged with sla:pending label. But I doubt it matters for a change of this size 😅. I'll check with @meysholdt |
Hi @measutosh, thanks for your contribution! We were a bit too quick, so please sign this CLA form as soon as you can :) |
tried many times but this error is still there |
@measutosh Are you still seeing this error when opening the CLA form linked above? The form renders fine here. |
Description
This PR solves the issue #13497 as suggested over there : 2 rows, 4 column style on-boarding IDE selector window
Related Issue(s)
Fixes #13497
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide