Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two rows of 4 option on onboarding IDE selector #13557

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Two rows of 4 option on onboarding IDE selector #13557

merged 1 commit into from
Oct 4, 2022

Conversation

75asu
Copy link
Contributor

@75asu 75asu commented Oct 4, 2022

Description

This PR solves the issue #13497 as suggested over there : 2 rows, 4 column style on-boarding IDE selector window

Related Issue(s)

Fixes #13497

How to test

Release Notes

   NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-measutosh-patch-1.0 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

/werft run with-preview

👍 started the job as gitpod-build-measutosh-patch-1-fork.0
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

/werft run with-preview

👍 started the job as gitpod-build-measutosh-patch-1-fork.1
(with .werft/ from main)

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @measutosh! 🍊

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

UX changes look good! ✔️

Someone from the @gitpod-io/engineering-webapp will pick this up for a code review. 🏀

@roboquat roboquat merged commit 34ceb07 into gitpod-io:main Oct 4, 2022
@laushinka
Copy link
Contributor

Very quick, @svenefftinge! Was the CLA signed yet?

@75asu
Copy link
Contributor Author

75asu commented Oct 5, 2022

Thanks for contributing, @measutosh! tangerine

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. ping_pong

UX changes look good! heavy_check_mark

Someone from the @gitpod-io/engineering-webapp will pick this up for a code review. basketball

thanks @gtsiolis for the MR

@svenefftinge
Copy link
Member

svenefftinge commented Oct 5, 2022

Very quick, @svenefftinge! Was the CLA signed yet?

Probably not. I was expecting that it wouldn't get merged with sla:pending label. But I doubt it matters for a change of this size 😅. I'll check with @meysholdt

@laushinka
Copy link
Contributor

laushinka commented Oct 7, 2022

Hi @measutosh, thanks for your contribution! We were a bit too quick, so please sign this CLA form as soon as you can :)

@75asu
Copy link
Contributor Author

75asu commented Oct 8, 2022

Hi @measutosh, thanks for your contribution! We were a bit too quick, so please sign this CLA form as soon as you can :)

tried many times but this error is still there
I had another query, do I need to rebase and force push again after the CLI sign or only the form is enough

image

@gtsiolis
Copy link
Contributor

@measutosh Are you still seeing this error when opening the CLA form linked above? The form renders fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update onboarding IDE selector
5 participants