Skip to content

Update onboarding IDE selector #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreafalzetti opened this issue Sep 30, 2022 · 4 comments · Fixed by #13557
Closed

Update onboarding IDE selector #13497

andreafalzetti opened this issue Sep 30, 2022 · 4 comments · Fixed by #13557

Comments

@andreafalzetti
Copy link
Contributor

    Nice catch, @andreafalzetti! Agree, let's go with a boring (simple) MVC fix like the two rows of four for now. 🤝 
diff --git a/components/dashboard/src/settings/SelectIDEModal.tsx b/components/dashboard/src/settings/SelectIDEModal.tsx
index e24318a74..dde3e3504 100644
--- a/components/dashboard/src/settings/SelectIDEModal.tsx
+++ b/components/dashboard/src/settings/SelectIDEModal.tsx
@@ -44,7 +44,7 @@ export default function (props: SelectIDEModalProps) {
             visible={visible}
             onClose={handleContinue}
             closeable={true}
-            className="_max-w-xl"
+            className="max-w-2xl"
             buttons={<button onClick={handleContinue}>Continue</button>}
         >
             <p className="text-gray-500 dark:text-gray-400 text-base pb-3">
BEFORE AFTER
Screenshot 2022-09-30 at 5 05 18 PM (2) Screenshot 2022-09-30 at 5 05 31 PM (2)

Originally posted by @gtsiolis in #13488 (comment)

@Siddhant-K-code
Copy link
Member

I can take that up 🙋‍♂️

@75asu
Copy link
Contributor

75asu commented Oct 4, 2022

Hi @andreafalzetti , I have modified the code as suggested above, raised a PR 13557.
Please have a look.

Thanks

@75asu
Copy link
Contributor

75asu commented Oct 4, 2022

I can take that up raising_hand_man

hey @Siddhant-K-code ,sorry for the MR , I know it's not good to pickup an issue where someone else is working but I just saw and jumped staright into this

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

It's ok @measutosh! Generally, it's best to avoid working on issues with already an assignee, but since a) this is a fairly trivial change, b) @andreafalzetti intentionally added the ~good-first-issue label here, and c) there was no open PR[1] from @andreafalzetti, let's move forward with the changes in #13557.

@andreafalzetti I've re-assigned this to @measutosh. 🍫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants