-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add RubyMine and WebStorm as IDEs #13488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99b6188
to
2704599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed! ✅
exampleRepo: https://github.com/gitpod-io/template-jetbrains-rubymine | ||
secrets: | ||
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }} | ||
webstorm: | ||
uses: ./.github/workflows/jetbrains-updates-template.yml | ||
with: | ||
productName: WebStorm | ||
productId: webstorm | ||
productCode: WS | ||
productType: release | ||
exampleRepo: https://github.com/gitpod-io/template-jetbrains-webstorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice [Non-Blocking]: We need to review/unarchive these two example repos:
- https://github.com/gitpod-io/template-jetbrains-rubymine
- https://github.com/gitpod-io/template-jetbrains-webstorm
/cc @loujaybee
Alternatively, we could use the following up-to-date templates for:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will take a look at them, shouldn't block this PR, though, right?
CC: @Siddhant-K-code - let's add this to the backlog to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think.
-
For webstorm:
template-typescript-react
is good & easy repo to test it out. This is outdated, but will not affect. -
For Rubymine:
template-ruby-on-rails-postgres
this looks outdated but yeah, this is a complex one to test.
But,
- Speciality in this
template-jetbrains-rubymine
because of this it fetches a registry from JetBrains. So this looks more better to test the integration & workflow. (Action Item: We need to Un-Archive it)
4cbbf81
to
eaf32fc
Compare
@mustard-mh, can we add the Werft option |
started the job as gitpod-build-hw-add-ide.4 because the annotations in the pull request description changed |
eaf32fc
to
fb78a35
Compare
On smaller screens the Continue button will be hidden because the modal does not scroll vertically. Shall we have 2 rows of 4 as a quick workaround until we find a better way? cc @gtsiolis |
Nice catch, @andreafalzetti! Agree, let's go with a boring (simple) MVC fix like the two rows of four for now. 🤝 diff --git a/components/dashboard/src/settings/SelectIDEModal.tsx b/components/dashboard/src/settings/SelectIDEModal.tsx
index e24318a74..dde3e3504 100644
--- a/components/dashboard/src/settings/SelectIDEModal.tsx
+++ b/components/dashboard/src/settings/SelectIDEModal.tsx
@@ -44,7 +44,7 @@ export default function (props: SelectIDEModalProps) {
visible={visible}
onClose={handleContinue}
closeable={true}
- className="_max-w-xl"
+ className="max-w-2xl"
buttons={<button onClick={handleContinue}>Continue</button>}
>
<p className="text-gray-500 dark:text-gray-400 text-base pb-3">
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so excited about this! Thanks @mustard-mh 🥇
I've tested both and they work great.
also, thanks @gtsiolis for jumping in and providing the changes 🙏
PS: I don't think the UX is a blocker, I will update the dashboard in a follow-up PR.
/unhold |
Description
Add RubyMine and WebStorm as IDEs 🎉
Related Issue(s)
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide