Skip to content

Add RubyMine and WebStorm as IDEs #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Add RubyMine and WebStorm as IDEs #13488

merged 3 commits into from
Sep 30, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Sep 30, 2022

Description

Add RubyMine and WebStorm as IDEs 🎉

Related Issue(s)

How to test

  • Open preview env, check IDE options added
  • Select RM and WS as IDE, open workspace check if it works
  • Open JetBrains Gateway, change Gitpod host to this preview env, and check if IDE options added
  • Check also GH Action

Release Notes

Add `RubyMine` and `WebStorm` IDEs

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed! ✅

Comment on lines +56 to +66
exampleRepo: https://github.com/gitpod-io/template-jetbrains-rubymine
secrets:
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
webstorm:
uses: ./.github/workflows/jetbrains-updates-template.yml
with:
productName: WebStorm
productId: webstorm
productCode: WS
productType: release
exampleRepo: https://github.com/gitpod-io/template-jetbrains-webstorm
Copy link
Contributor

@felladrin felladrin Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will take a look at them, shouldn't block this PR, though, right?

CC: @Siddhant-K-code - let's add this to the backlog to review.

Copy link
Member

@Siddhant-K-code Siddhant-K-code Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think.

@mustard-mh mustard-mh force-pushed the hw/add-ide branch 2 times, most recently from 4cbbf81 to eaf32fc Compare September 30, 2022 12:32
@felladrin
Copy link
Contributor

@mustard-mh, can we add the Werft option /werft with-large-vm, to allow more people to test simultaneously?

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-add-ide.4 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

On smaller screens the Continue button will be hidden because the modal does not scroll vertically. Shall we have 2 rows of 4 as a quick workaround until we find a better way? cc @gtsiolis
Screenshot 2022-09-30 at 14 59 02

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 30, 2022

Nice catch, @andreafalzetti! Agree, let's go with a boring (simple) MVC fix like the two rows of four for now. 🤝

diff --git a/components/dashboard/src/settings/SelectIDEModal.tsx b/components/dashboard/src/settings/SelectIDEModal.tsx
index e24318a74..dde3e3504 100644
--- a/components/dashboard/src/settings/SelectIDEModal.tsx
+++ b/components/dashboard/src/settings/SelectIDEModal.tsx
@@ -44,7 +44,7 @@ export default function (props: SelectIDEModalProps) {
             visible={visible}
             onClose={handleContinue}
             closeable={true}
-            className="_max-w-xl"
+            className="max-w-2xl"
             buttons={<button onClick={handleContinue}>Continue</button>}
         >
             <p className="text-gray-500 dark:text-gray-400 text-base pb-3">
BEFORE AFTER
Screenshot 2022-09-30 at 5 05 18 PM (2) Screenshot 2022-09-30 at 5 05 31 PM (2)

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM!

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it works

Webstorm Rubymine
image image

/hold in case someone wants to check

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so excited about this! Thanks @mustard-mh 🥇

I've tested both and they work great.

also, thanks @gtsiolis for jumping in and providing the changes 🙏

PS: I don't think the UX is a blocker, I will update the dashboard in a follow-up PR.

@andreafalzetti
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 12361f0 into main Sep 30, 2022
@roboquat roboquat deleted the hw/add-ide branch September 30, 2022 16:33
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants