Skip to content

[dashboard] Update theme preference selector #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Apr 16, 2021 · 2 comments · Fixed by #4021
Closed

[dashboard] Update theme preference selector #3984

gtsiolis opened this issue Apr 16, 2021 · 2 comments · Fixed by #4021
Assignees
Labels
changelog worth adding to www.gitpod.io/changelog component: dashboard type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 16, 2021

Problem to solve

The first part of the dark theme has been added in #3901. However, we are still missing a better styled theme selector.

Theme Selector
Screenshot 2021-04-16 at 10 51 06 PM

Proposal

We could:

  1. Update the theme selector style to follow the design language of the rest of the product and make the option more appealing to the user. This could use something like the card component used above in the editor preference.
  2. Default to light theme to be less surprising to the user. Preference order could be Light, Dark, System.
  3. Update the section design description to something more descriptive or maybe playful like Early bird or night owl? Choose your side.
  4. Consider introducing a secondary option to sync theme between dashboard and editor, see [dashboard] Sync theme preference between dashboard and editor #3982 (comment).

Designs

Light Dark
image image

See also design specs.

@gtsiolis gtsiolis added component: dashboard needs visual design type: improvement Improves an existing feature or existing code labels Apr 16, 2021
@gtsiolis gtsiolis added this to the April 2021 milestone Apr 16, 2021
@gtsiolis gtsiolis self-assigned this Apr 19, 2021
@gtsiolis gtsiolis removed their assignment Apr 20, 2021
@jankeromnes jankeromnes self-assigned this Apr 20, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 20, 2021

Looks awesome! ✨ Many thanks @gtsiolis. 🙏

Additional thought: Once implemented, it could be nice to just copy/paste this Theme switcher into the "What's New" modal (thus allowing users to switch the Theme directly from What's New). Thoughts? 😇

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 20, 2021

Absolutely @jankeromnes! That was the plan, similarly to what @AlexTugarev did with the account select process in #3897. But haven't thought this through yet in terms of how this design will scale but it should could be fine. Will cross-check and post any updates in #3956. 🤷

@jankeromnes jankeromnes added the changelog worth adding to www.gitpod.io/changelog label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog worth adding to www.gitpod.io/changelog component: dashboard type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants