Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild status indicator on "Branches" can be misleading #5908

Closed
Tracked by #10361
geropl opened this issue Sep 28, 2021 · 5 comments · Fixed by #10661
Closed
Tracked by #10361

Prebuild status indicator on "Branches" can be misleading #5908

geropl opened this issue Sep 28, 2021 · 5 comments · Fixed by #10661
Assignees
Labels
component: dashboard feature: admin dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience

Comments

@geropl
Copy link
Member

geropl commented Sep 28, 2021

Situation: Th status indicator for the branch says "Ready" (because a prebuild for a former commit exists), but the current HEAD has none (yet). Because the branch details contain a commit (short) hash I as a user assume the commit and prebuild are connected (and wonder why I can a workspace build on the wrong commit), while they aren't.
image

Possible solutions:

  • shows status indicator for latest commit only (incl. none if for whatever reasons there is no prebuild for the latest commit, yet)
  • remove commit details, and make the view about branches only
  • somehow make transparent that here possibly is are a lot of prebuilds, one for each commit (no idea how to display that)
@geropl geropl added feature: admin dashboard type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Sep 28, 2021
@JanKoehnlein
Copy link
Contributor

@gtsiolis What do you think?

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 30, 2021

Thanks @geropl! Going with the first proposal to show status indicator for latest commit only sounds a good step forward.

FWIW, We do have design specs most prebuild status phases including PENDING, RUNNING, etc. and I can see the RUNNING state popping up when a new prebuild is triggered.

question: Are we not surfacing a prebuild phase here?

Branches with prebuilds status
Screenshot 2021-09-30 at 1 17 36 PM

This will be also needed in the branches details page being added in #5903.

@stale
Copy link

stale bot commented Feb 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 24, 2022
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Feb 24, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Feb 24, 2022
@geropl geropl mentioned this issue May 31, 2022
11 tasks
@laushinka
Copy link
Contributor

@geropl I tested this and couldn't reproduce it. I committed to both a new and an existing branch, and the prebuild statuses were consistent in both the "Branches" and "Prebuilds" tabs. I can show you sync or create a Loom, to make sure I understand the supposed bug.

@geropl
Copy link
Member Author

geropl commented Jun 13, 2022

@laushinka The problem here is that on the "Branches" view, the "Prebuild" column is filled if we have any prebuild for the respective branch. But the "Commit" column always shows the latest commit.

Not sure how to reproduce, though. But should be fairly straight forward to find in the code. Happy to sync after the meeting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: admin dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants