[prebuilds] make sure prebuild and branch commits are the same #10661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laushinka
force-pushed
the
laushinka/prebuild-status-indicator-5908
branch
from
9e7c6de to
6d547d9
Compare
laushinka
force-pushed
the
laushinka/prebuild-status-indicator-5908
branch
from
6d547d9 to
036215c
Compare
AlexTugarev
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
LGTM! Thanks @laushinka!
This change makes sense. There might be a gap between fetching latest commit via API and getting a push event via webhook to get processed. This will ensure, we're not rendering unrelated items.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue in #5908 wasn't able to be reproduced, but this PR is to make sure that it doesn't happen.
When a prebuild's commit hash and branch's latest commit hash don't align, then we don't show the prebuild status in
/branches.Some prebuild namings are also improved here.
Related Issue(s)
Fixes #5908
How to test
Release Notes
Documentation