Deleting a team does not remove member access to team pages and resources

[gtsiolis]

Bug description

Changes in #5966 (Cc @laushinka @JanKoehnlein) introduced the ability to delete teams. However, deleting a team 🅰️ does not actually remove the rest of the team members and 🅱️ the rest of the team previously added as members or owners can still access team page, add projects, open workspaces, and trigger prebuilds. See #5966 (comment).

Steps to reproduce

1. Create a team.
2. Invite another team member.
3. Delete the team as a team owner.
4. Notice that as a team member you can still access team page, add projects, open workspaces, and trigger prebuilds.

Expected behavior

Possibly redirecting back to the personal account when a user tries to access resources for a deleted team could work.

Example repository

No response

Anything else?

No response

[laushinka]

@JanKoehnlein and I tested it just now and when a team was deleted, I got a 404 when I tried to access any of the team's pages, and I tried it again just now. Could you show me?

[gtsiolis]

@laushinka hm, have you tried accessing the deleted team as a previously invited team member of that deleted team?

[laushinka]

@gtsiolis Yikes, you're right. So an owner can't access it but a member can. Thanks for catching it 🙏🏽

[laushinka]

I will look into this.

[gtsiolis]

Thanks @laushinka! 🙏

[gtsiolis]

Cross-posting a closely related edge case from #5894 (comment) for visibility in case we also need to handle (remove) the deleted team from the local storage:

One edge case is what happens when a user is removed from a team or a team is deleted. Probably defaulting back to the personal account sounds reasonable, right? 🧀

Because of #5854 (Cc @AlexTugarev) this issue impacts also users coming back to the dashboard after some time to load and access the team pages even if that team was deleted in the meantime. Feel free to open a separate issue for this if needed. 🏓

[laushinka]

/assign @laushinka