-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[projects] clear team selection #5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replying to #5854 (comment) in this open PR:
Agree and this already happens for example when you visit the admin dashboard, right? One edge case is what happens when a user is removed from a team or a team is deleted. Probably defaulting back to the personal account sounds reasonable, right? 🧀 See also relevant discussion (internal). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised! Many thanks for the quick fix.
I still think it's dangerous & only slightly helpful to add this kind of "magic behavior" to our app, but I'm okay with this for now. Maybe let's remove this feature if we notice that it creates new bugs? (We already have a lot of feature creep in Gitpod).
LGTM label has been added. Git tree hash: db4f4da203aa9aa776d8473ad0d861371ae9848a
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, jankeromnes Associated issue requirement bypassed by: AlexTugarev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup to #5854
In this change we clear the team selection whenever a non-team page is loaded.
Related Issue(s)
Fixes #
How to test
Release Notes