Skip to content

Open up JetBrains without admin flag (feature preview flag) #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loujaybee opened this issue Nov 1, 2021 · 11 comments · Fixed by #6505
Closed

Open up JetBrains without admin flag (feature preview flag) #6485

loujaybee opened this issue Nov 1, 2021 · 11 comments · Fixed by #6505

Comments

@loujaybee
Copy link
Member

loujaybee commented Nov 1, 2021

Currently, the JetBrains integration is behind an is admin feature flag. This issue is to remove that feature flag, and replace with a feature preview toggle OR to simply update the copy text for the dashboard to make it clear that the feature is BETA and to include any information around feedback etc.

@loujaybee loujaybee self-assigned this Nov 1, 2021
@corneliusludmann
Copy link
Contributor

I'm in favor of removing the feature flag and making it clear in the description that it's a BETA feature (was also proposed by Sven).

@corneliusludmann
Copy link
Contributor

Do you have any suggestions for the actual text for the BETA box, @loujaybee?

image

@loujaybee loujaybee removed their assignment Nov 2, 2021
@loujaybee
Copy link
Member Author

So the important things we should note either on this page or in our docs are:

  1. It's currently "password" protected, and what the password is.
  2. The implementation will put data through Code With Me / JetBrains servers.
  3. Where to submit feedback (we don't yet have a GitHub issue, we need to make one)

Is there anything I'm missing? Also cc: @atduarte

The new page has a footer with the following text:

Screenshot 2021-11-02 at 13 36 04

To keep things consistent how about: "The JetBrains desktop IDE's are currently in beta. Send feedback and refer to our documentation for more information."

Note: We'll probably have to reword when we integrate VSCode Desktop onto that page. We can then update the website docs with the information in points 1. and 2. and store any future FAQ's and additional information on our website/docs page.

What do you think? Also cc: @jldec / @gtsiolis any further thoughts/input?

@corneliusludmann
Copy link
Contributor

Proposal:


image


Suggestions for improvement or better wording are very welcome.

@loujaybee
Copy link
Member Author

loujaybee commented Nov 2, 2021

Looks good to me @corneliusludmann

Note: I've now created a separate issue for any changes to the external-facing docs #6524

@jldec
Copy link
Contributor

jldec commented Nov 2, 2021

For consistency, I'd suggest Beta instead of BETA or beta.
See #6010 (comment) and (internal) thread

@jldec
Copy link
Contributor

jldec commented Nov 2, 2021

I would maybe move the Beta warning down and make it less loud/noisy.

I quite like the very terse, small, green pill + grey link (except on hover) which GitHub uses in the new Projects Beta.

Screenshot 2021-11-02 at 17 49 15

@corneliusludmann
Copy link
Contributor

Regarding capitalization of “BETA”: That the word “beta” next to the logo is written in upper case is because the pile labels we use are styled like this across the product (designed by @gtsiolis, I guess). We also use the pile label for the “INSIDERS” label next to VS Code. To be consistent with the pile label components we should keep upper case, IMO. However, we could also agree on designing a dedicated Beta label instead.

@corneliusludmann corneliusludmann self-assigned this Nov 3, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 4, 2021

Hey everyone!

Thanks @corneliusludmann for adding the proposal in #6485 (comment) and including the background context in #6485 (comment)! 🙏 ✖️ 2️⃣

🍊 🍊 🍊 🍊

Here're some thoughts on this design and the beta label:

  1. thought: Going with uppercase or sentence case for the beta labels sounds good. No strong feelings on both directions. However, we could leave this out of the scope of this issue and work on a dedicated beta label as @corneliusludmann mentioned in Open up JetBrains without admin flag (feature preview flag) #6485 (comment).
  2. suggestion: Could we skip repeating the beta label on both JetBrains IDEs as both are currently in beta? Eventually we could remove the label on both and keep improving the integrations, right? Unless we plan to keep to gradually bringing in other beta options one-by-one and marking them as beta. Cc @loujaybee
  3. question: What do you think of moving the beta notice below as @jldec mentioned in Open up JetBrains without admin flag (feature preview flag) #6485 (comment), to make the interface less verbose and use the same pattern (footer note + links) for the beta notice we use also for teams
    and projects (see /teams/new)? Using a global beta for this section sound better, no? See screenshot below.
  4. question: Could we skip the info alert about the password needed and include this in the documentation? If not, what do you think of moving the info alert also below as a footnote? Simplifying the copy could also help.

Screenshot 2021-11-04 at 11 55 42 PM

@corneliusludmann
Copy link
Contributor

2. suggestion: Could we skip repeating the beta label on both JetBrains IDEs as both are currently in beta? Eventually we could remove the label on both and keep improving the integrations, right? Unless we plan to keep to gradually bringing in other beta options one-by-one and marking them as beta.

As far as I know, in the near future we will add VS Code Destkop to the list of desktop IDEs (which will not be “Beta”). Therefore the labels next to the 2 JetBrains IDE would make more sense than next to “Use Desktop IDE”.

@corneliusludmann
Copy link
Contributor

corneliusludmann commented Nov 5, 2021

Updated the draft PR. Now it looks like this:

image

The last thing that is missing in the PR is the proper link to the feedback issue. @loujaybee

EDIT: Done ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants