-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] Remove feature flag for desktop IDEs #6505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7319465
to
f9a8935
Compare
f9a8935
to
7f6229d
Compare
7f6229d
to
3e4004c
Compare
Rebased on |
/werft run 👍 started the job as gitpod-build-clu-open-up-jetbrains-6485.6 |
The preview env worked as expected even though the build failed. |
Thanks, @laushinka! For some reason, the I will restart a slate deployment since it seems that is related to the deployment after the rebase. |
werft job is green now |
/lgtm |
LGTM label has been added. Git tree hash: 4dbedf5da2dc02a3e4e00a67913973c254c8263f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laushinka Associated issue: #6485 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR removes the check that hides the desktop IDE preferences for non-admin users.
To Do
Related Issue(s)
Fixes #6485
How to test
Open the preferences page as a not-admin user (remove the role in the admin page) and make sure the desktop IDE settings are present.
Release Notes
/no-cc