-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove supervisor gRPC metrics and process metrics #10063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run 👍 started the job as gitpod-build-pd-del-grcp-metrics.1 |
To help me understand better, in this PR we introduced the metrics but we are now removing them. If I understand correctly, we are only removing a subset of the metrics (gRPC metrics and process metrics) but we are keeping some? What type of metrics are we keeping? |
@andreafalzetti See also gitpod-io/observability#121 (comment) we delete it because we are not interesting with it and the storage is expensive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold |
Ohhh Tide, hold too late😞 Too fast when you want to hold, too slow (even pending pool) when you want to merge |
See also internal chat @andreafalzetti |
Description
Remove supervisor gRPC metrics and process metrics, because we don't interested supervisor metrics context
Related Issue(s)
Fixes #
How to test
curl http://localhost:22999/metrics
it should be emplyecho "gitpod_some_metric 3.14" | curl --data-binary @- http://localhost:22999/metrics/job/some_job
curl http://localhost:22999/metrics
again it should be only havegitpod_some_metric
andpushgateway
metricsRelease Notes
Documentation