Skip to content

Remove supervisor gRPC metrics and process metrics #10063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 17, 2022

Description

Remove supervisor gRPC metrics and process metrics, because we don't interested supervisor metrics context

Related Issue(s)

Fixes #

How to test

  1. start a workspace
  2. run curl http://localhost:22999/metrics it should be emply
  3. run echo "gitpod_some_metric 3.14" | curl --data-binary @- http://localhost:22999/metrics/job/some_job
  4. run curl http://localhost:22999/metrics again it should be only have gitpod_some_metric and pushgateway metrics

image

Release Notes

NONE

Documentation

@iQQBot
Copy link
Contributor Author

iQQBot commented May 17, 2022

/werft run

👍 started the job as gitpod-build-pd-del-grcp-metrics.1
(with .werft/ from main)

@iQQBot iQQBot marked this pull request as ready for review May 17, 2022 13:24
@iQQBot iQQBot requested a review from a team May 17, 2022 13:24
@mustard-mh mustard-mh self-requested a review May 17, 2022 13:25
@andreafalzetti
Copy link
Contributor

To help me understand better, in this PR we introduced the metrics but we are now removing them. If I understand correctly, we are only removing a subset of the metrics (gRPC metrics and process metrics) but we are keeping some?

What type of metrics are we keeping?

@andreafalzetti andreafalzetti self-requested a review May 17, 2022 14:56
@mustard-mh
Copy link
Contributor

To help me understand better, in #9815 we introduced the metrics but we are now removing them. If I understand correctly, we are only removing a subset of the metrics (gRPC metrics and process metrics) but we are keeping some?
What type of metrics are we keeping?

@andreafalzetti See also gitpod-io/observability#121 (comment) we delete it because we are not interesting with it and the storage is expensive

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm XD

image

@mustard-mh
Copy link
Contributor

/hold

@roboquat roboquat merged commit d950656 into main May 17, 2022
@roboquat roboquat deleted the pd/del-grcp-metrics branch May 17, 2022 15:00
@mustard-mh
Copy link
Contributor

mustard-mh commented May 17, 2022

Ohhh Tide, hold too late😞

Too fast when you want to hold, too slow (even pending pool) when you want to merge

@mustard-mh
Copy link
Contributor

See also internal chat @andreafalzetti

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production do-not-merge/hold release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants