-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics push gateway for supervisor #9815
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspace portion LGTM
@iQQBot Should there be changes in ws-proxy which prohibit access to metrics endpoint by anyone else but prometheus? |
No, We don't access from the ws-proxy, and besides, the supervisor endpoint can't be set to public, so there's no real point in preventing users from accessing it themselves; they can always access localhost:22999 from within the workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/unhold |
Description
This PR allow prometheus to scrape metrics from supervisor, and allow IDE push metrics to supervisor
need manual add this CRD to clusters, this is another part for https://github.com/gitpod-io/observability
Related Issue(s)
Fixes #9515
How to test
latest
vscodeRelease Notes
Documentation