[dashboard] Fix Prebuilds item truncate

[flaming-codes]

Description

This PR fixes a small truncation issue w/ text in the Prebuilds items.

Related Issue(s)

Fixes #9103

How to test

No specific tests for this change are available.

Release Notes

NONE

Documentation

Screenshots

Description	Image
Before fix
After fix

[gtsiolis]

/werft run

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.0
(with .werft/ from main)

[gtsiolis]

/werft run

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.1
(with .werft/ from main)

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[flaming-codes]

@gtsiolis I signed the CLA, so everything should have been fine to merge those changes. Is there anything on my side to do, so that contributions are accepted? Thanks!

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[flaming-codes]

@gtsiolis What's the status on this from your side? I signed the CLA a long time ago, is there anything to do on my part? Thanks!

[gtsiolis]

Thanks for reaching out, @flaming-codes! Let me link the comment from #10268 (comment).

[jankeromnes]

/werft run

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.2
(with .werft/ from main)

[jankeromnes]

/werft run with-preview

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.3
(with .werft/ from main)

[jankeromnes]

/werft run with-preview

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.4
(with .werft/ from main)

[jankeromnes]

Many thanks for improving this!

Since the preview doesn't want to come up, I tried testing this on the live Gitpod app using my browser devtools.

I believe this improves the situation a bit, but in general, I'm somewhat unhappy with the general state of our table/column layout (in the Prebuilds list and the Workspaces list). We seem to be using truncate and overflow-hidden somewhat at random (sometimes multiple times on elements and their containers), yet some columns still don't have a consistent width in some layouts.

Ideally, in the future, we could clean this up by:

• Using a consistent width for all "column" top-level containers in an element, combined with overflow-hidden (this strictly prevents columns from growing larger than they should -- e.g. long branchnames currently overflow)
• Using truncate on every text sub-element that might have overflowing text (so that the hard cut of the text is not too "brutal" but has an ellipsis ...)

Still, no point in delaying this improvement of the status quo because there are also other possible improvements to be made. 🙂 Thus, approving this PR.

Many thanks!

[jankeromnes]

Trying to bypass the failing build using a build without a preview:

/werft run

👍 started the job as gitpod-build-fix-prebuilds-item-truncate-fork.5
(with .werft/ from main)

[geropl]

/hold to unblock merge pool

[jankeromnes]

Thanks! Should pass auto-merge now:

/unhold

[flaming-codes]

Hi team,

there were a lot of merge conflicts when trying to update my PR with the latest changes - no wonder, as my initial fix is now almost 2 months old, as of writing.

I think I neither have the time nor energy to spend to fix PR-conflicts for such small changes, therefore I propose to delete this PR and apply the initial fix w/ a new one.

Thanks for all your work and Gitpod as a product, but these super long delays in my PR reviews that result in only fixing conflicts isn't the experience I yearn for.

All the best,
Tom

[jankeromnes]

Hi @flaming-codes,

Sorry that it took so long to review your changes that so many conflicts appeared... We're still not very good at reviewing community contributions in a consistent and timely manner, and we have a lot to learn & to improve there.

I'd totally understand if you don't have the time or energy to re-do the fix in a new PR. As an alternative, I believe I could salvage your commit into a new PR, and work towards merging that one. Would you be okay with this? I'd cc you on the new PRs so that you can follow along if interested, and since you've already signed the CLA, there would be no further actions needed on your part.

Thanks again,
Jan

[flaming-codes]

Hi Jan,

As an alternative, I believe I could salvage your commit into a new PR, and work towards merging that one. Would you be okay with this?

Sure, works fine for me!