-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore(dashboard): adjust prebuild table col width #10564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e463eca
to
388098a
Compare
@AlexTugarev Could you review this PR (tomorrow)? 🙏 |
Happy to take a look 👀 |
/werft run 👍 started the job as gitpod-build-afalz-webapp-prebuilds-col-width.3 |
@@ -190,7 +190,7 @@ export default function (props: { project?: Project; isAdminDashboard?: boolean | |||
</div> | |||
<ItemsList className="mt-2"> | |||
<Item header={true}> | |||
<ItemField className="my-auto w-5/12"> | |||
<ItemField className="my-auto md:w-3/12 xl:w-4/12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to not overshoot at md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip for the future: Using CSS grid is much more powerful and robust in these situation than trying to guess good fixed widths.
With grid, you can simply specify "I want three columns of exactly the same width", or specify custom relative column widths, but they'll almost always be correct regardless of screen size, margins, size of content, etc.
@jankeromnes, are you still looking at this? This seems to fix a bigger issue, and I'm keen to merge it as is. wdyt? |
Ah, yes, thanks for the reminder. Triggered a build then forgot about this. Resuming review now. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving our Prebuilds list! ✨
I tested this change at various resolutions, and with various commit messages / branch name lengths. I think the current implementation is still not perfect (e.g. might need an ellipsis + tooltip on the branch name) hence the hold, but please feel free to merge this when you like (this is easy to adjust later as well).
FYI, here are my test results:
My normal screen size | Max screen size | Smartphone (>50% of web users) | iPad (portrait) |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Tip: To automatically add an ellipsis to a potentially super long cell (e.g. the branch name), you can add:
- the
truncate
CSS class - a
title
attribute with the exact same text content as the element (so that users can still hover over the truncated text to see the full text)
See also how the commit message is truncated for inspiration.
/hold
Oh, wait, I wonder if #10472 maybe already fixes the same issue? 👀 Looks like we may need a |
should be merged or closed? |
@jankeromnes @AlexTugarev is it alright to remove hold? |
Description
The Prebuilds page not always align correctly the columns, e.g. see screeenshot below:
I think this small CSS change could improve already some scenarios.
Related Issue(s)
N/A
How to test
(I would also suggest Prev Env, but there are no prebuilds there)
Release Notes