-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Clean code from GitpodServerLauncher and update JetBrains backend-plugin to work when user has proxies #11307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ts/gitpod-protocol/java/src/main/java/io/gitpod/gitpodprotocol/api/GitpodServerLauncher.java
Outdated
Show resolved
Hide resolved
...ts/gitpod-protocol/java/src/main/java/io/gitpod/gitpodprotocol/api/GitpodServerLauncher.java
Outdated
Show resolved
Hide resolved
...ts/gitpod-protocol/java/src/main/java/io/gitpod/gitpodprotocol/api/GitpodServerLauncher.java
Show resolved
Hide resolved
afe1b95
to
1e68cc4
Compare
…gin to work when user has proxies
1e68cc4
to
1ef9ba2
Compare
...ts/gitpod-protocol/java/src/main/java/io/gitpod/gitpodprotocol/api/GitpodServerLauncher.java
Show resolved
Hide resolved
I wasn't able to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did not try, but code changes looks good.
/hold
if someone wants to test, if not please merge
just look at logs and see what JB backend can connect to Gitpod API |
Description
Clean code from GitpodServerLauncher and update JetBrains backend-plugin to work when the user has proxies.
This reverts the hotfix from #11232 and passes a default
SslContextFactory
toHttpClient
, which the root cause of the issue #11228. For reference, this is the error message the server was triggering:Related Issue(s)
Resolves #11291
How to test
env | grep GITPOD_INSTANCE_ID
Release Notes
Documentation
None.
Werft options: