Skip to content

Release/2022.06.1 - NOT TO BE MERGED #11411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

nandajavarma and others added 14 commits June 27, 2022 12:02
A [regression by Replicated](replicated-collab/replicated-gitpod#27)
introduced a breaking change to how to deploy KOTS releases that included
a Helm chart between v1.72.0 and v1.72.2. The [change](replicatedhq/kots@77690e5)
only affects manifests that use native Helm but the legacy implementation
inside KOTS.
…pshot CRD exists

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
An errant `git rebase` accidentally merged in the customer ID into telemetry
data, bypassing a later check in telemetry collection that checked the `sendCustomerID`
field. This commit restores the appropriate check.
This PR updates the new preview installation method, to be
called `local-preview`. This is part of the recent change
across the documentation https://github.com/gitpod-io/website/pull/2326

The image tag is still `preview-install` in the readme's and other
documentations, but it will be updated once we start publishing
releases with it.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Fixes #10766

This PR adds a new `experimental.telemetry.data.platform` config option
that is then passed to `GITPOD_INSTALLATION_PLATFORM` env variable, which
is then transmitted by the `gitpod-telemetry` job as the `platform`
property into our telemetry store. The value of this env variable
is then overrided by each install method.

This env can have the following values:
- `installer` by default as when the installation is done directly
  through the installer, We don't have enough information
   about the environment.
-  [One of the `distribution` values](https://docs.replicated.com/reference/template-functions-static-context#distribution)
   when done through `kots`. This would have the distribution in which
   Gitpod is being installed, and is dependent on `kots`.
- `local-preview` when the installation is done through the new
   preview install method.

As the changes show in the PR, each installation method overrides
the value.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Currently, It takes a while before Gitpod is ready even though
the status says `Gitpod is running` as its not checking for
readyness.

This PR updates the output to separate btw `starting` and `running`.
`Gitpod is running` message is showed only when we see that
the `gitpod-telemetry-init` job has run which happens when
all pods are ready.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Due to the way docker works in non-native platforms, It is
very hard to have a consistent experience across all platforms
as we can't just use the [docker bridge netwrok IP's in non-native
platforms](https://docs.docker.com/desktop/networking/). This means that
users have to search their Host IP, and use It
to get up and working [which we tried, but understand that it's not
a good UX](https://github.com/gitpod-io/website/pull/2349).

But users can use `127-0-0-1.nip.io` as the DOMAIN which resolves to
 `127.0.0.1` and is available in all platforms as its `localhost`. This
works well and good for all user communication
but internal communication fails as `127-0-0-1.nip.io` for them
is something else.

So, This PR fixes that by adding new coredns
`gitpod.db` coredns config essentially asking to route all
`127-0-0-1.nip.io` to `proxy.default.svc.cluster.local`. [As k3s does
not yet support overriding coredns config in a sane-way](k3s-io/k3s#462)
,We instead skip the default coredns by adding `coredns.yaml.skip` file,
and adding our own `custom-coredns.yaml` which is just plain
`coredns.yaml` that comes with `k3s`, added with gitpod config.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
This PR updates the `local-preview` to printout
the Domain of the Gitpod Instance for users to
access.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
@roboquat
Copy link
Contributor

@mrsimonemms: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jul 15, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-release-2022.06.1.4
(with .werft/ from main)

felladrin and others added 2 commits July 18, 2022 07:50
This PR updates the `entry-point.sh` to run a parallel step
that waits for the gitpod pods to be ready, and manually executes
the cronjob once its necessary.

This is necessary as our telemetry `cronjobs` are only ran
daily in the midnight, and we can't expect this schedule to work
for local previews as they are short lived.

example data that we get:

```
client.Track(&analytics.Track{
  UserId: "334c379a-afee-4882-ba44-fbd7dfc0a8b0",
  Event: "Installation telemetry",
  Properties: map[string]interface{}{
    "customerID": "",
    "platform": "local-preview",
    "totalInstances": 0,
    "totalUsers": 0,
    "totalWorkspaces": 0,
    "version": "tar-preview-tel-init.4",
  },
})
```

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jul 18, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-release-2022.06.1.7
(with .werft/ from main)

@mrsimonemms mrsimonemms deleted the release/2022.06.1 branch July 18, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants