Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local-preview] show DOMAIN in the output #11341

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

Pothulapati
Copy link
Contributor

@Pothulapati Pothulapati commented Jul 13, 2022

Description

This PR updates the local-preview to printout
the Domain of the Gitpod Instance for users to
access.

Signed-off-by: Tarun Pothulapati tarun@gitpod.io

Related Issue(s)

Part of #11316

How to test

docker run -p 443:443 --privileged --name gitpod --rm -it -v gitpod:/var/gitpod eu.gcr.io/gitpod-core-dev/build/local-preview:tar-local-preview-domain.0

Release Notes

[local-preview] show `DOMAIN` in the output

Documentation

Werft options:

  • /werft with-preview

@Pothulapati Pothulapati requested a review from a team July 13, 2022 09:58
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-tar-local-preview-domain.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jul 13, 2022
@Pothulapati Pothulapati force-pushed the tar/local-preview-domain branch from 3995a3d to 748ff80 Compare July 13, 2022 10:38
@Pothulapati Pothulapati marked this pull request as draft July 13, 2022 10:49
@Pothulapati Pothulapati force-pushed the tar/local-preview-domain branch 2 times, most recently from 2033d13 to cc9ef92 Compare July 13, 2022 10:57
@roboquat roboquat added size/S and removed size/M labels Jul 13, 2022
@Pothulapati Pothulapati force-pushed the tar/local-preview-domain branch from cc9ef92 to 3852247 Compare July 13, 2022 10:58
@roboquat roboquat added size/XS and removed size/S labels Jul 13, 2022
@Pothulapati Pothulapati force-pushed the tar/local-preview-domain branch 2 times, most recently from aeaecaf to 99ede96 Compare July 13, 2022 11:32
This PR updates the `local-preview` to printout
the Domain of the Gitpod Instance for users to
access.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
@Pothulapati Pothulapati force-pushed the tar/local-preview-domain branch from 99ede96 to d30d44a Compare July 13, 2022 11:46
@roboquat roboquat added size/S and removed size/XS labels Jul 13, 2022
@Pothulapati Pothulapati marked this pull request as ready for review July 13, 2022 12:10
@Pothulapati Pothulapati requested a review from mrsimonemms July 13, 2022 12:11
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on an Intel mac, LGTM 👍

@roboquat roboquat merged commit eefee55 into main Jul 13, 2022
@roboquat roboquat deleted the tar/local-preview-domain branch July 13, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants