[ws-manager-bridge] Remove HasUserLevel admission constraint #11383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never really used it and solved this case with other means
This was referenced Jul 14, 2022
csweichel
commented
Jul 14, 2022
| @@ -58,7 +58,7 @@ message AdmissionConstraint { | |||
| oneof constraint { | |||
| FeaturePreview has_feature_preview = 1; | |||
| HasPermission has_permission = 2; | |||
| string has_user_level = 3; | |||
| // deprecated anr removed: has_user_level = 3; | |||
There was a problem hiding this comment.
typo is fixed later in the PR stack
github-actions
bot
added
team: webapp
sagor999
approved these changes
Jul 14, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
has-user-leveladmission constraint. We never actually used this constrained, so it was just deadweight.This PR is part of a stack of changes:
How to test
This PR should not actually incur functional changes of any sort.
Release Notes
Werft options: