Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "has-maturity-level" admission constraint #11385

Closed
wants to merge 2 commits into from

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 14, 2022

Description

This PR introduces a new admission constraint: has-maturity-level. There are three maturity levels: low, default, high.

In combination with a new mature-workspace-clusters permission we can now mark risk-averse users. Once a user has this permission, they will prefer clusters with the high maturity level. If no such cluster exists, they'll fall back to the usual cluster selection. This is implemented just by adding a new workspace cluster set to the cluster selection.

This PR is part of a stack of changes:

How to test

  1. start a workspace - nothing should change for regular users
  2. add the mature-workspace-clusters permission to your user using the admin panel. Starting a workspace should work as it did before.
  3. register a new cluster (e.g. by copying and modifying the entry in the database) and add the has-maturity-level admission constraint. Your user should now land on that cluster.

Release Notes

NONE

Werft options:

  • /werft with-preview

@csweichel
Copy link
Contributor Author

csweichel commented Jul 14, 2022

/werft run

👍 started the job as gitpod-build-cw-add-wsac-maturity.1
(with .werft/ from main)

@csweichel csweichel force-pushed the cw/remove-wsac-hmr branch from dc5269a to 96db6fd Compare July 15, 2022 07:55
@csweichel csweichel force-pushed the cw/add-wsac-maturity branch from 1795acd to e3c7eeb Compare July 15, 2022 07:59
Base automatically changed from cw/remove-wsac-hmr to main July 15, 2022 12:31
@csweichel csweichel force-pushed the cw/add-wsac-maturity branch from e3c7eeb to 26e06eb Compare July 15, 2022 12:48
@csweichel
Copy link
Contributor Author

csweichel commented Jul 20, 2022

/werft run

👍 started the job as gitpod-build-cw-add-wsac-maturity.4
(with .werft/ from main)

@stale
Copy link

stale bot commented Jul 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 30, 2022
@stale stale bot closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/XXL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants