[installer]: add in ability to post-process #11391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
2 times, most recently
from
1f42764 to
2f7014c
Compare
github-actions
bot
added
the
team: delivery
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
from
2f7014c to
0005267
Compare
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
from
0005267 to
a213fbb
Compare
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
from
a213fbb to
35b9060
Compare
Pothulapati
reviewed
Jul 19, 2022
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
from
35b9060 to
d6dad48
Compare
This removes the "status" block on the root, which breaks older versions of Kubernetes
mrsimonemms
force-pushed
the
sje/installer-post-process
branch
from
d6dad48 to
4e2d985
Compare
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to post-process the Installer's YAML natively in the Golang binary. This extends the YQ library, so any valid YQ expression can be used to amend the generated YAML.
It also removes the
statusobject from both Network Policies and Stateful Sets, both of which are problematic when supporting multiple versions of Kubernetes.This also removes the problems associated with upgrades to the Kubernetes libraries (eg #11003) and allows for #11177 to be merged.
How to test
Run the Installer, there should be no
statusin anyNetworkPolicyor the OpenVSXProxyStatefulSetresources.Release Notes
Documentation
Werft options: