Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[public-api] Validate incoming stripe webhooks #12441

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Aug 26, 2022

Description

Implements validation of Stripe Webhooks.

Uses secret already mounted to the public-api-server to perform the validation as per Stripe documentaiton.

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch 3 times, most recently from 57ad453 to 1d01cd0 Compare August 29, 2022 09:34
@easyCZ easyCZ changed the base branch from main to mp/papi-stripe-secret-fix August 29, 2022 09:35
@easyCZ easyCZ force-pushed the mp/papi-stripe-secret-fix branch from b4fb538 to a2b4a38 Compare August 29, 2022 09:36
@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch from 1d01cd0 to 77c4a0e Compare August 29, 2022 09:40
@easyCZ
Copy link
Member Author

easyCZ commented Aug 29, 2022

/hold for dependency

@easyCZ easyCZ marked this pull request as ready for review August 29, 2022 09:50
@easyCZ easyCZ requested a review from a team August 29, 2022 09:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 29, 2022
Base automatically changed from mp/papi-stripe-secret-fix to main August 29, 2022 10:01
@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch from 1e170bc to dfde75e Compare August 29, 2022 10:02
@easyCZ easyCZ requested a review from a team August 29, 2022 10:03
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 29, 2022
@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch 2 times, most recently from 68836f2 to 98d0238 Compare August 29, 2022 10:06
@easyCZ easyCZ removed request for a team, akosyakov and csweichel August 29, 2022 10:07
@easyCZ
Copy link
Member Author

easyCZ commented Aug 29, 2022

/unhold

@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch from 98d0238 to 18a610e Compare August 29, 2022 11:07
@easyCZ easyCZ force-pushed the mp/stripe-validate-webhook branch from 18a610e to f387b2e Compare August 29, 2022 11:39
@roboquat roboquat merged commit 40ab42e into main Aug 29, 2022
@roboquat roboquat deleted the mp/stripe-validate-webhook branch August 29, 2022 11:58
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants