[public-api] Fix Stripe Webhook Secret mount path #12462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/papi-stripe-secret-fix
branch
from
b4fb538 to
a2b4a38
Compare
easyCZ
commented
Aug 29, 2022
| @@ -16,7 +16,3 @@ type Configuration struct { | |||
|
|
|||
| Server *baseserver.Configuration `json:"server,omitempty"` | |||
| } | |||
|
|
|||
| type StripeSecret struct { | |||
There was a problem hiding this comment.
Removing this as we'll not be needing the struct for the secret
1 task
geropl
approved these changes
Aug 29, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation would mount the secret under
/stripe-secret/stripe-webhook-secretbut would set the config path tosecrets/stripe-secret. This fixes that issue by fixing the path.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: