Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update render tests #12447

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update render tests #12447

merged 1 commit into from
Aug 26, 2022

Conversation

mads-hartmann
Copy link
Contributor

Description

The most recent build on main failed (ref) due to render tests failing. They passed on the PR that was merged though.

From reading slack I ran the following commands to update the golden files:

cd install/installer && make deps generateRenderTests

Related Issue(s)

No issue

How to test

Hopefully this fixes the tests.

Release Notes

none

Documentation

N/A

Werft options:

  • /werft with-preview

@mads-hartmann mads-hartmann requested review from a team August 26, 2022 18:10
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team labels Aug 26, 2022
@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Aug 26, 2022

@gitpod-io/engineering-ide tagging you for review as the metrics are related to your component, and @gitpod-io/engineering-self-hosted just in case this isn't how you're supposed to update the golden files ☺️

@roboquat roboquat merged commit 0fc1903 into main Aug 26, 2022
@roboquat roboquat deleted the mads/fix-render-tests branch August 26, 2022 18:49
@roboquat roboquat added the deployed: IDE IDE change is running in production label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production release-note-none size/S team: delivery Issue belongs to the self-hosted team team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants