[usage] Add listing of credit balance #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
andrew-farries
approved these changes
Sep 7, 2022
|
|
||
| type Balance struct { | ||
| AttributionID AttributionID `gorm:"column:attributionId;type:varchar;size:255;" json:"attributionId"` | ||
| CreditCents CreditCents `gorm:"column:creditCents;type:bigint;" json:"creditCents"` |
There was a problem hiding this comment.
I may have missed this discussion elsewhere but what is the purpose of the CreditsCents type? When we wrote the other reconciler we always stored credit values as floating point values.
There was a problem hiding this comment.
Basically it stores credits * 100 rounded. This removes precision errors. Here, we use a custom type to represent that it's not credits, but credits * 100, or CreditCents
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements retrieval of credit balance for all attribution IDs in the Usage table. Will be used when updating invoices against Stripe.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: