[billing] Implement ReconcileInvoices #12712
Conversation
easyCZ
force-pushed
the
mp/billing-reconcile-invoices
branch
from
c5fb522 to
7d9e602
Compare
| invoice, err := c.GetUpcomingInvoice(ctx, customer.ID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to find upcoming invoice for customer %s: %w", customer.ID, err) | ||
| } | ||
|
|
||
| _, err = c.UpdateInvoiceMetadata(ctx, invoice.ID, map[string]string{ | ||
| ReportIDMetadataKey: summary.ReportID, | ||
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to udpate invoice %s metadata with report ID: %w", invoice.ID, err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Dropping this part as
- It already doesn't work as we can't update an UpcomingInvoice in Stripe with metadata
- We're no longer planning to use the metadata for sharing the report
easyCZ
force-pushed
the
mp/billing-reconcile-invoices
branch
from
7d9e602 to
5a2c563
Compare
easyCZ
changed the base branch from
main
to
mp/billing-reconcile-invoices-proto
easyCZ
force-pushed
the
mp/billing-reconcile-invoices-proto
branch
from
5eb6411 to
33d67f5
Compare
easyCZ
force-pushed
the
mp/billing-reconcile-invoices
branch
from
5a2c563 to
559b00a
Compare
easyCZ
force-pushed
the
mp/billing-reconcile-invoices
branch
from
559b00a to
34ef9cb
Compare
|
|
||
| creditSummaryForTeams[id] = stripe.CreditSummary{ | ||
| Credits: int64(math.Ceil(balance.CreditCents.ToCredits())), | ||
| ReportID: "no-report", |
There was a problem hiding this comment.
This will be removed later, once we remove the other usage of the ReportID, for now it doesn't hurt us in any way as we do not use it during the UsageUpdate invoked below.
| } | ||
| } | ||
|
|
||
| err = s.stripeClient.UpdateUsage(ctx, creditSummaryForTeams) |
There was a problem hiding this comment.
If I read correctly here, we might fail to update if the very first query is for a costCenter without stripe account, no?
There was a problem hiding this comment.
We fail if we fail to lookup customers from stripe. But we then iterate over the stripe customers which actually exist rather than over all the attribution IDs so in this case it would not fail on the first which doesn't have a stripe account.
| return nil, status.Errorf(codes.Internal, "Failed to reconcile invoices.") | ||
| } | ||
|
|
||
| creditSummaryForTeams := map[string]stripe.CreditSummary{} |
There was a problem hiding this comment.
Can we generalize and talk about attributeId instead of teams?
There was a problem hiding this comment.
Yes, this requires a couple of changes. For one we need to start setting the attributionId: <value> on stripe customers rather than the teamId we set now
| entity, id := balance.AttributionID.Values() | ||
|
|
||
| // TODO: Support updating of user attribution IDs | ||
| if entity != db.AttributionEntity_Team { |
There was a problem hiding this comment.
why do we need this exclusion here?
There was a problem hiding this comment.
Legacy of the focus on team based UBP first.
roboquat
added
deployed: webapp
Description
Implements reconciliation of usage balances against Stripe.
Related Issue(s)
How to test
Release Notes
Documentation
Werft options: