Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intial prometheus rules for cardinality analysis #14235

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

ArthurSens
Copy link
Contributor

Signed-off-by: ArthurSens arthursens2005@gmail.com

Description

Creates recording rules so Prometheus intances pre-compute queries that can be used for cardinality analysis

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but couple of spelling mistakes (analysis is a tricky word to spell)

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@ArthurSens ArthurSens force-pushed the as/cardinality-analysis branch from b11e21e to 0817cca Compare October 27, 2022 12:39
@roboquat roboquat merged commit 652da9d into main Oct 27, 2022
@roboquat roboquat deleted the as/cardinality-analysis branch October 27, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants