Fix timeseries_total recording rule #14247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
|
started the job as gitpod-build-as-fix-timeseries-total-recordingrule.1 because the annotations in the pull request description changed |
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
|
/werft run 👍 started the job as gitpod-build-as-fix-timeseries-total-recordingrule.3 |
|
started the job as gitpod-build-as-fix-timeseries-total-recordingrule.4 because the annotations in the pull request description changed |
ArthurSens
commented
Oct 27, 2022
Comment on lines
+47
to
+48
| - gitURL: https://github.com/gitpod-io/gitpod | ||
| path: operations/observability/mixins/self-hosted/rules/cardinality-analysis |
There was a problem hiding this comment.
Oh, actually this can't be tested in the preview environment because the file is not on main yet 😅
Unfortunately, there is no way of testing this one besides merging and checking results
adrienthebo
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArthurSens arthursens2005@gmail.com
Description
After #14235, we got alerted about failures in rule evaluation. After some investigation, I've came up with a fix
Related Issue(s)
kubectl port-forward -n monitoring-satellite prometheus-k8s-0 9090metric:timeseries_total, you should see resultsHow to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide