Skip to content

[supervisor] make it compatible with run-gp #15480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Dec 22, 2022

Description

This PR introduces changes to supervisor to make it work nicely when running inside run-gp. Some changes will actually skip some logic from supervisor which is not required. Other changes are extending supervisor capabilities to fetch tasks from 2 supervisor instances.

Related Issue(s)

Fixes #

How to test

https://ak-merge-run-tasks.preview.gitpod-dev.com/workspaces

Start a workspace and test for regressions for gp tasks

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-merge-run-tasks.3 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/XL and removed size/L labels Dec 22, 2022
@akosyakov akosyakov marked this pull request as ready for review December 22, 2022 14:44
@akosyakov akosyakov requested a review from a team December 22, 2022 14:44
@andreafalzetti andreafalzetti changed the title [supervisor] merge run tasks [supervisor] make it compatible with run-gp Dec 22, 2022
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Dec 22, 2022

/werft run

👍 started the job as gitpod-build-ak-merge-run-tasks.8
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the ak/merge_run_tasks branch 2 times, most recently from 0a6ba8c to 4608ac5 Compare December 22, 2022 15:44
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Dec 22, 2022

/werft run recreate-preview

👍 started the job as gitpod-build-ak-merge-run-tasks.12
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Dec 22, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-ak-merge-run-tasks.13
(with .werft/ from main)

@akosyakov
Copy link
Member Author

closing in favor of #15490

@akosyakov akosyakov closed this Dec 23, 2022
@akosyakov akosyakov deleted the ak/merge_run_tasks branch December 23, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants